Upgrade eslint and extract config #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- upgrade eslint to 5.15.3 - upgrade eslint-plugin-import to 2.16.0 - correctly use the import plugin - remove linebreak-style (fixes #502) - use eslint:recommended (fixes #589, fixes #480) In a later change we should turn on airbnb-base for maintaining via a script that switches this. In a later change, we should turn on several rules that guard against potential bugs, such as `no-shadow` `no-undefined` `no-var`; additionally we can add stylistic consistency without forcing style choises such as consistent spacing (but not required).
SleeplessByte
added
the
chore 🔧
4 tasks
tejasbubane
approved these changes
Mar 25, 2019
SleeplessByte
added a commit
that referenced
this pull request
Dec 16, 2020
Has been fixed since #645, but the file was still ignoring directories.
SleeplessByte
added a commit
that referenced
this pull request
Dec 16, 2020
Has been fixed since #645, but the file was still ignoring directories.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a later change we should turn on airbnb-base for maintaining via a script that switches this.
In a later change, we should turn on several rules that guard against potential bugs, such as
no-shadowno-undefinedno-var; additionally we can add stylistic consistency without forcing style choises such as consistent spacing (but not required).