Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade eslint and extract config #645

Merged
merged 3 commits into from
Mar 25, 2019
Merged

Upgrade eslint and extract config #645

merged 3 commits into from
Mar 25, 2019

Commits on Mar 25, 2019

  1. Upgrade eslint and extract config 

    - upgrade eslint to 5.15.3
- upgrade eslint-plugin-import to 2.16.0
- correctly use the import plugin
- remove linebreak-style (fixes #502)
- use eslint:recommended (fixes #589, fixes #480)

In a later change we should turn on airbnb-base for maintaining via a script that switches this.

In a later change, we should turn on several rules that guard against potential bugs, such as `no-shadow` `no-undefined` `no-var`; additionally we can add stylistic consistency without forcing style choises such as consistent spacing (but not required).
    @SleeplessByte
    SleeplessByte committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    83a6d2f View commit details
    Browse the repository at this point in the history

  2. Saving files before refreshing line endings

    @SleeplessByte
    SleeplessByte committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    baf4283 View commit details
    Browse the repository at this point in the history

  3. Normalize all the line endings

    @SleeplessByte
    SleeplessByte committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    384ddc3 View commit details
    Browse the repository at this point in the history