Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize GitHub actions #875

Merged
merged 28 commits into from
Oct 19, 2020
Merged

Optimize GitHub actions #875

merged 28 commits into from
Oct 19, 2020

Conversation

SleeplessByte
Copy link
Member

@SleeplessByte SleeplessByte commented Oct 16, 2020 •
edited
Loading

Has to be merged after #874.

This PR aims to make it easier to run much more actions on PRs without it slowing down the entire CI.

  • Split out configlet to a single action that runs once
  • Split out running tests (3 node versions, LTS, previous and next) from linting/stub-checking/etc (LTS only)
  • Design new ci scripts pr and pr-check which only run on exercises that have changed.
  • Use the babel-node cli, so that the scripts themselves can be written in ES6.

This PR does not sync/update all exercises here in order to keep it a bit more clean. See the next PR.

@SleeplessByte SleeplessByte added do not merge 🚧 Don't merge until this label is removed chore 🔧 Meta related task such as build, test, linting, maintainers.json etc. labels Oct 16, 2020
@SleeplessByte SleeplessByte changed the title Chore/optimize GitHub actions Optimize GitHub actions Oct 17, 2020
@SleeplessByte SleeplessByte added hacktoberfest-accepted Opt-in to hacktoberfest and removed do not merge 🚧 Don't merge until this label is removed labels Oct 17, 2020
This was referenced Oct 17, 2020
Merged
Closed
Closed
Open
SaschaMann
SaschaMann reviewed Oct 17, 2020
View reviewed changes
Copy link
Contributor

@SaschaMann SaschaMann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not check the changes to the scripts, only the workflow files.

.github/workflows/ci.precheck.yml Outdated Show resolved Hide resolved
.github/workflows/ci.precheck.yml Outdated Show resolved Hide resolved
.github/workflows/pr.ci.js.yml Outdated Show resolved Hide resolved
.github/workflows/pr.precheck.yml Outdated Show resolved Hide resolved
SaschaMann
SaschaMann reviewed Oct 17, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@SleeplessByte SleeplessByte mentioned this pull request Oct 18, 2020
Merged
iHiD
iHiD reviewed Oct 19, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
iHiD
iHiD reviewed Oct 19, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
SleeplessByte and others added 17 commits October 20, 2020 00:59
@SleeplessByte SleeplessByte merged commit a1b6525 into master Oct 19, 2020
@SleeplessByte SleeplessByte deleted the chore/optimize-github-actions branch October 19, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaMann SaschaMann SaschaMann left review comments

@iHiD iHiD iHiD approved these changes

@tejasbubane tejasbubane Awaiting requested review from tejasbubane

@ErikSchierboom ErikSchierboom Awaiting requested review from ErikSchierboom

Assignees
No one assigned
Labels
chore 🔧 Meta related task such as build, test, linting, maintainers.json etc. hacktoberfest-accepted Opt-in to hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SleeplessByte @iHiD @SaschaMann