Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leap is dead, long live leap! #365

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Leap is dead, long live leap! #365

wants to merge 1 commit into from

Conversation

SaschaMann
Copy link
Contributor

@iHiD I'd appreciate it if you could check that I did everything correctly

@SaschaMann SaschaMann requested a review from iHiD April 4, 2021 16:22
@SaschaMann SaschaMann requested a review from a team as a code owner April 4, 2021 16:22
@SaschaMann SaschaMann added the v3 🚀 Issues that need to be resolved for the launch of v3 label Apr 4, 2021
@SaschaMann SaschaMann added the do not merge 🚧 Don't merge until this label is removed label Apr 13, 2021
@SaschaMann SaschaMann marked this pull request as draft April 13, 2021 17:51
@ee7
Copy link
Member

ee7 commented Sep 7, 2021

Just FYI: configlet lint will soon say something like:

The slug leap is used for both a Concept Exercise and a Practice Exercise, but must only appear once on the track:
./config.json

until there's only one leap. But it looks like this PR is handling it.

(I haven't reviewed this PR).

@ee7 ee7 mentioned this pull request Sep 7, 2021
Merged
@iHiD
Copy link
Member

iHiD commented Sep 7, 2021

@ErikSchierboom Could you check this PR locally pls?

@ErikSchierboom
Copy link
Member

@SaschaMann There is a merge conflict, could you fix that?

@SaschaMann
Copy link
Contributor Author

I'll leave it until we enable concept exercises. Otherwise it deprecates leap for no good reason.

@SaschaMann SaschaMann mentioned this pull request Oct 12, 2021
Closed
@SaschaMann SaschaMann mentioned this pull request Mar 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iHiD iHiD Awaiting requested review from iHiD

@ErikSchierboom ErikSchierboom Awaiting requested review from ErikSchierboom

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
do not merge 🚧 Don't merge until this label is removed v3 🚀 Issues that need to be resolved for the launch of v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SaschaMann @ee7 @iHiD @ErikSchierboom