Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest versions #51

Merged
merged 9 commits into from
Mar 7, 2023
Merged

Update to latest versions #51

merged 9 commits into from
Mar 7, 2023

Conversation

ejc123
Copy link
Contributor

@ejc123 ejc123 commented Feb 27, 2023

Updated Dockerfile to the latest Erlang 25.2.3.0 image

Updated dependencies:
Replaced rebar3_lfe_compile with rebar3_lfe (0.4.3) as the former was deprecated and points to the latter
Updated ltest to latest version 0.13.3
Updated lfe to latest version 2.1.1

All of the dependencies are available from hex.

I had to modify the expected_results.json files due to minor changes in the output. Things still passed/failed as expected. I also added a 'description' to each of the .app.src files to quiet a compiler warning.

@ejc123 ejc123 requested a review from a team as a code owner February 27, 2023 02:54
@github-actions
Copy link

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Feb 27, 2023
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Could you maybe also add a new test case that uses the old setup to see if that still works?

@ejc123
Copy link
Contributor Author

ejc123 commented Feb 28, 2023

I tried, but the old rebar.config will not work. There was a breaking change between rebar 3.15.x and 3.16 which breaks the old lfe-compile plugin.
It might be possible to install rebar 3.15.2 in docker, but Erlang versions newer than 19.0 will warn about removed functions that LFE 1.1.1 uses.
Not sure about the best path forward.

@ErikSchierboom
Copy link
Member

Okay, then I would propose we do the following:

  • Before merging this PR, we'll add rebar.config to an exercise's files.invalidator field in it's .meta/config.json file. Once this is merging, changing the rebar.config for an exercise will prompt a student to update, which we can then use to do a follow-up PR to update the exercises in the exercism/lfe repository to use the latest rebar.config. See https://github.com/exercism/scala/pull/735/files for an example of such a PR.
  • After merging those two PRs, we can merge this.

@ejc123
Copy link
Contributor Author

ejc123 commented Mar 3, 2023

That's really slick. So nothing will change for students until the rebar.config changes are pushed? So rebar.lock would be updated in the same commit as rebar.config, correct?

@ejc123
Copy link
Contributor Author

ejc123 commented Mar 3, 2023

PR for adding rebar.config to exercise's files.invalidator field exercism/lfe#166

@ErikSchierboom
Copy link
Member

So nothing will change for students until the rebar.config changes are pushed?

Well, if they would run their tests without updating their exercise, they would get an error. But they would be able to update their exercise via a simple process.

So rebar.lock would be updated in the same commit as rebar.config, correct?

Correct!

@ejc123
Copy link
Contributor Author

ejc123 commented Mar 5, 2023

This PR exercism/lfe#163 will update all the rebar.config and rebar.lock files.

The top-level documentation looks pretty good. There's a reference to a docker image in INSTALLATION.md which doesn't work for me, but I'm not sure if that's my setup or that it is 6 years old.
Would it be a good idea to remove this reference until an updated image is available?

@ErikSchierboom
Copy link
Member

The top-level documentation looks pretty good. There's a reference to a docker image in INSTALLATION.md which doesn't work for me, but I'm not sure if that's my setup or that it is 6 years old.
Would it be a good idea to remove this reference until an updated image is available?

I think so.

@ejc123
Copy link
Contributor Author

ejc123 commented Mar 7, 2023

I updated INSTALLATION.md so exercism/lfe#163 is ready to go. Let me know if there are any other things that need to happen before these changes can be merged.
Otherwise I'll just let you merge things at your convenience.

@ErikSchierboom ErikSchierboom merged commit 8eeca23 into exercism:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants