-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest versions #51
Conversation
Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed. That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Could you maybe also add a new test case that uses the old setup to see if that still works?
I tried, but the old rebar.config will not work. There was a breaking change between rebar 3.15.x and 3.16 which breaks the old |
Okay, then I would propose we do the following:
|
That's really slick. So nothing will change for students until the |
PR for adding |
Well, if they would run their tests without updating their exercise, they would get an error. But they would be able to update their exercise via a simple process.
Correct! |
This PR exercism/lfe#163 will update all the The top-level documentation looks pretty good. There's a reference to a docker image in |
I think so. |
I updated |
Updated Dockerfile to the latest Erlang 25.2.3.0 image
Updated dependencies:
Replaced
rebar3_lfe_compile
withrebar3_lfe
(0.4.3) as the former was deprecated and points to the latterUpdated
ltest
to latest version 0.13.3Updated
lfe
to latest version 2.1.1All of the dependencies are available from hex.
I had to modify the
expected_results.json
files due to minor changes in the output. Things still passed/failed as expected. I also added a 'description' to each of the.app.src
files to quiet a compiler warning.