-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #163
Update dependencies #163
Conversation
Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed. That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Two things need to happen before this can be merged:
- The test runner needs to be updated to support the new packages, ideally remaining backwards compatible with old solutions
- Add the
rebase
file(s?) as invalidator files. Currently,, therebar.config
(andrebar.lock
) file changes won't prompt students to update their solutions, as it is not listed in the exercise's files in the.meta/config.json
file. For files that are not shown to the student but should still influence up-to-date checks, we have anfiles.invalidator
field.
I would recommend creating a separate PR adding the rebar.config
file of each exercise to the files.invalidator
field in each exercise's .meta/config.json
file. I don't know if it makes sense to alow have the rebar.lock
file in there, but probably not I guess.
See https://github.com/exercism/fsharp/pull/1101/files for an example PR.
As I look into this more, the more I see that's outdated. The Docker image is |
That would be brilliant!
Down the rabbit hole! |
Note: exercism/lfe-test-runner#51 should be merged first. |
Thanks! |
I updated the dependencies to the latest versions.
The package
rebar3_lfe_compile
moved torebar3_lfe
github repo so I changed that dependency and updated it.I tested it with one exercise (hamming) as I was unable to get
make test
to work so I updated the dependencies and was able to successfully run the tests. All the config files look the same so I think it should work with all the others.