Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #163

Merged
merged 5 commits into from
Mar 7, 2023
Merged

Update dependencies #163

merged 5 commits into from
Mar 7, 2023

Conversation

ejc123
Copy link
Contributor

@ejc123 ejc123 commented Jan 16, 2023

I updated the dependencies to the latest versions.

The package rebar3_lfe_compile moved to rebar3_lfe github repo so I changed that dependency and updated it.

I tested it with one exercise (hamming) as I was unable to get make test to work so I updated the dependencies and was able to successfully run the tests. All the config files look the same so I think it should work with all the others.

@github-actions
Copy link

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jan 16, 2023
@iHiD iHiD reopened this Jan 16, 2023
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Two things need to happen before this can be merged:

  1. The test runner needs to be updated to support the new packages, ideally remaining backwards compatible with old solutions
  2. Add the rebase file(s?) as invalidator files. Currently,, the rebar.config (and rebar.lock) file changes won't prompt students to update their solutions, as it is not listed in the exercise's files in the .meta/config.json file. For files that are not shown to the student but should still influence up-to-date checks, we have an files.invalidator field.

I would recommend creating a separate PR adding the rebar.config file of each exercise to the files.invalidator field in each exercise's .meta/config.json file. I don't know if it makes sense to alow have the rebar.lock file in there, but probably not I guess.

See https://github.com/exercism/fsharp/pull/1101/files for an example PR.

@ejc123
Copy link
Contributor Author

ejc123 commented Jan 18, 2023

As I look into this more, the more I see that's outdated. The Docker image is erlang:19.3.6.13 which is not even on the list of supported images anymore. I am willing to put the effort into updating everything and making separate PRs for different aspects.
I am running the latest versions of erlang, lfe, and rebar3. I can also update the documentation as needed to reflect new versions.
I only started on this because rebar3 was failing while trying to compile 😄

@ErikSchierboom
Copy link
Member

I am willing to put the effort into updating everything and making separate PRs for different aspects.
I am running the latest versions of erlang, lfe, and rebar3. I can also update the documentation as needed to reflect new versions.

That would be brilliant!

I only started on this because rebar3 was failing while trying to compile 😄

Down the rabbit hole!

@ErikSchierboom
Copy link
Member

Note: exercism/lfe-test-runner#51 should be merged first.

@ErikSchierboom ErikSchierboom merged commit 6264aa6 into exercism:main Mar 7, 2023
@ErikSchierboom
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants