Clean up documentation for x-api v3 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are failing, but rerunning the tests on master also makes them fail, which is odd, since those tests used to pass. Not sure what's going on. |
|
Looks like the version of LFE getting pulled is using rebar3, so I'll have to update everything accordingly. As such, I've opened #13. |
|
Ok, thanks! |
The tests are broken and LFE supports rebar3 now, which is great.
In order to get xlfe working with rebar3, I had to update all the
`Makefile`s and `rebar.config`s. The deps symlinks to point to ../_build
and the test make target uses _build/default/lib/... instead of deps/...
Now the tests pass! 🎉
- Update .travis.yml
- Can't run rebar3 without downloading it first...
- Add PWD to PATH so make can find rebar3.
- Update test script
- ({"init terminating in do_boot",
{badarg, [{erl_prim_loader,check_file_result,3,[]},
{init, get_boot, 1, []},
... ]})
make: *** [test] User defined signal 2
- 💋 and use maps
- Update config.json
- Ignore _build
yurrriq
added a commit
that referenced
this pull request
Nov 26, 2015
Clean up documentation for x-api v3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in support of ditching the help site and integrating the docs into the main site's language-specific pages (served via the same API that serves the exercise data).