Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

word-count: Add test for multiple whitespace #1023

Merged
merged 2 commits into from
Nov 28, 2017

Conversation

jonmcalder
Copy link
Member

See #1022 for reference

@@ -111,6 +111,15 @@
"large": 2,
"and": 1
}
},
{
"description": "with multiple whitespace",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more helpful description would be nice.
What is it about multiple whitespace that makes it interesting to test?

"space surrounded by spaces not detected as a word"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - a valid point. I fell into the trap of just imitating the overly brief descriptions from some of the prior test cases...

@jonmcalder
Copy link
Member Author

Thanks @ErikSchierboom!

@jonmcalder jonmcalder merged commit 8793a05 into exercism:master Nov 28, 2017
@jonmcalder jonmcalder deleted the word-count branch November 28, 2017 20:57
tejasbubane added a commit to tejasbubane/haskell that referenced this pull request Mar 25, 2019
sshine pushed a commit to exercism/haskell that referenced this pull request Mar 26, 2019
marko213 added a commit to marko213/exercism-cpp that referenced this pull request Jul 30, 2019
Adds three test cases:

* substrings_from_the_beginning (exercism/problem-specifications#1557)
* multiple_spaces_not_detected_as_a_word (exercism/problem-specifications#1023)
* alternating_word_separators_not_detected_as_a_word (exercism/problem-specifications#1446)
arcuru pushed a commit to exercism/cpp that referenced this pull request Aug 5, 2019
* Word-count - update tests specification to version 1.4.0

Adds three test cases:

* substrings_from_the_beginning (exercism/problem-specifications#1557)
* multiple_spaces_not_detected_as_a_word (exercism/problem-specifications#1023)
* alternating_word_separators_not_detected_as_a_word (exercism/problem-specifications#1446)

* Word-count - change test cases to be more like the specification (1.4.0)

This reorders and removes some tests to match the specification in version 1.4.0

* Word-count - make empty lines uniform in test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants