series, largest-series-product: clarify "consecutive" #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| series of 3 digits is 270 (9 * 5 * 6), and the largest product for a | ||
| series of 5 digits is 7560 (7 * 8 * 3 * 9 * 5). | ||
|
|
||
| Note that these series are only required to occupy *adjacent positions* in the original string; the digits need not be *numerically consecutive*. |
There was a problem hiding this comment.
wrap? Considering that the above lines are wrapped
There was a problem hiding this comment.
Yeah, wrap. I always read the readmes either by opening them in a text editor, or catting them out onto the command-line. I like the wrapping.
It was unclear whether "consecutive" meant consecutive in *numerical value* or simply *positionally adjacent*. Due to this problem's origin in Project Euler, it was the latter. To avoid any confusion this commit does the following: * Replace the word "consecutive" in .yml files with "contiguous" * Clarifies in the .md files that the series of digits only need be positionally adjacent, not consecutive in numerical value. * Uses examples in .md files that should make clear that numerical value is not important. This should prevent any further confusion of the form expressed in the two issues * exercism/ruby#244 * exercism/ruby#262 This is the first subtask of #197.
|
wrapped to 72 |
kytrinyx
added a commit
that referenced
this pull request
Mar 13, 2016
series, largest-series-product: clarify "consecutive"
This was referenced Mar 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was unclear whether "consecutive" meant consecutive in numerical
value or simply positionally adjacent. Due to this problem's origin
in Project Euler, it was the latter.
To avoid any confusion this commit does the following:
positionally adjacent, not consecutive in numerical value.
is not important.
This should prevent any further confusion of the form expressed in the
two issues
This is the first subtask of #197.