Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strain: Add canonical data #2214

Merged
merged 4 commits into from Mar 14, 2023

Conversation

natanaelsirqueira
Copy link
Sponsor Contributor

@natanaelsirqueira natanaelsirqueira commented Mar 2, 2023

Following the discussion that happened in this topic, this PR adds canonical data for the Strain exercise, using a list of test cases that have been implemented by the majority of the tracks.

Closes #588

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Mar 2, 2023
@petertseng
Copy link
Member

Please amend the commit message to include the string "closes https://github.com/exercism/problem-specifications/issues/588" or any equivalent string. Thank you.

This request is not affected by the fact that that issue is already closed. This commit should be marked as closing it anyway, even though it is already closed. That way all commits relevant to that issue remain accessible from that issue.

@IsaacG IsaacG reopened this Mar 2, 2023
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work! A couple of minor nits.

exercises/strain/canonical-data.json Outdated Show resolved Hide resolved
exercises/strain/canonical-data.json Outdated Show resolved Hide resolved
exercises/strain/canonical-data.json Outdated Show resolved Hide resolved
exercises/strain/canonical-data.json Outdated Show resolved Hide resolved
exercises/strain/canonical-data.json Outdated Show resolved Hide resolved
natanaelsirqueira and others added 3 commits March 2, 2023 08:12
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! Excellent PR

@ErikSchierboom
Copy link
Member

CC @exercism/reviewers

Copy link
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you @natanaelsirqueira 🏅

@ErikSchierboom
Copy link
Member

CC @exercism/reviewers

@IsaacG IsaacG merged commit 40815e2 into exercism:main Mar 14, 2023
@natanaelsirqueira natanaelsirqueira deleted the strain-add-canonical-data branch March 14, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

strain: Implement canonical-data.json
6 participants