Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom-set: add test for removing duplicates #2436

Merged
merged 2 commits into from
May 10, 2024
Merged

custom-set: add test for removing duplicates #2436

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39b3572
custom-set: add test for removing duplicates
senekor May 9, 2024
9da56b7
fix oopsie
senekor May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions exercises/custom-set/canonical-data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,16 @@
"set2": [2, 4]
},
"expected": [1, 3]
},
{
"uuid": "20d0a38f-7bb7-4c4a-ac15-90c7392ecf2b",
"description": "difference removes all duplicates in the first set",
"property": "difference",
"input": {
"set1": [1, 1],
"set2": [1]
},
"expected": [0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the expected set [0]? Where does element 0 come from? Shouldn't I expect an empty set as the difference?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think that might be a mistake?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that was a mistake. thanks!

}
]
},
Expand Down