Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to fix crypto text normalization. #28

Merged
merged 1 commit into from
Oct 15, 2014
Merged

Update to fix crypto text normalization. #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions crypto-square.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ right.
For example, the message above is coded as:

```plain
imtgd vsfea rwerm ayoog
oanou uiont nnlvt wttdd
esaoh ghnss eoau
imtgdvs fearwer mayoogo
anouuio ntnnlvt wttddes
aohghn sseoau
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like the correct chunk size to me. The plaintext version is in chunks of 8, this is chunks of 7 except for the last two chunks which are 6. That's inconsistent with other behavior that I've seen.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right. The two spaces between the last two also look wrong, now that I give it a second look.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the cipher text is correct and that various current example solutions are incorrect. Compare with the the original problem description at the source referenced in the yml. The description in the readme looks consistent with the source document. This cipher text looks consistent with the descriptions and this is the cipher text given on the source page. I think it is the code which doesn't match the specification.

The two spaces between the last word is also copied from the source page. We could specify to put those extra spaces in, but I'd be in favor of taking them out of our readme. I think we should also show this on a single line,

imtgdvs fearwer mayoogo anouuio ntnnlvt wttddes aohghn sseoau

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I left a lengthy comment on the original ticket, #28. Sorry if it was the wrong place.

```

Write a program that, given an English text, outputs the encoded version
Expand All @@ -55,7 +55,7 @@ wide.
A message between 5 and 8 characters long should use a rectangle 3
characters wide.

Output the encoded text in groups of five letters.
Output the encoded text grouped by column.

For example:

Expand Down