-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bob: Update to clarify ambiguity regarding shouted questions #89
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Note in case someone wonders in the future: I checked our Bob exercise, and we do have the updated test for a forceful question in it. Therefore I also removed the wontfix label as this has been fixed. |
@mawis I just started the PureScript track, and I don't see the updated test. If I'm understanding things correctly, the test is still incorrect: test "forceful questions" do
Assert.equal "Whoa, chill out!" $
Bob.hey "WHAT THE HELL WERE YOU THINKING?" I believe the expected value is If so, can we reopen this issue? |
Thanks for pointing this out @chuckwondo and I believe you are correct. The current exercise instructions include the rule:
...and is an exact copy of the problem specification description. In the related canonical data file the expected response is indeed: "Calm down, I know what I'm doing!" This issue should be reopened. |
Addresses exercism/issues/89 (awaiting to be reopened)
An additional response was added to the problem specification but the forceful question unit test was incorrect. The response should be "Calm down, I know what I'm doing!" because "WHAT THE HELL WERE YOU THINKING?" is both a question and a yell. See: exercism/issues/89 (awaiting to be reopened)
An additional response was added to the problem specification but the forceful question unit test was incorrect. The response should be "Calm down, I know what I'm doing!" because "WHAT THE HELL WERE YOU THINKING?" is both a question and a yell. See: /issues/89 (awaiting to be reopened)
TL;DR: the problem specification for the Bob exercise has been updated. Consider updating the test suite for Bob to match. If you decide not to update the exercise, consider overriding description.md.
Details
The problem description for the Bob exercise lists four conditions:
There's an ambiguity, however, for shouted questions: should they receive the "asking" response or the "shouting" response?
In exercism/problem-specifications#1025 this ambiguity was resolved by adding an additional rule for shouted questions.
If this track uses exercise generators to update test suites based on the canonical-data.json file from problem-specifications, then now would be a good time to regenerate 'bob'. If not, then it will require a manual update to the test case with input "WHAT THE HELL WERE YOU THINKING?".
See the most recent canonical-data.json file for the exact changes.
Remember to regenerate the exercise README after updating the test suite:
You can download the most recent configlet at https://github.com/exercism/configlet/releases/latest if you don't have it.
If, as track maintainers, you decide that you don't want to change the exercise, then please consider copying problem-specifications/exercises/bob/description.md into this track, putting it in
exercises/bob/.meta/description.md
and updating the description to match the current implementation. This will let us run the configlet README generation without having to worry about the bob README drifting from the implementation.The text was updated successfully, but these errors were encountered: