Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Travis cache (issue #23) #24

Merged
merged 1 commit into from
Mar 21, 2017

Conversation

icyrockcom
Copy link
Contributor

Pull request for #23

@paf31
Copy link
Contributor

paf31 commented Mar 16, 2017

@lpil Are you familiar with this code?

@lpil
Copy link
Sponsor Member

lpil commented Mar 16, 2017

The original script is an adaption of one I pinched from (I think) the Haskell repo. The changes look good to me. :)

I wonder if it's possible to share the common deps so they don't need to be compiled for each project. Probably one for a later PR.

@icyrockcom
Copy link
Contributor Author

@lpil

I wonder if it's possible to share the common deps so they don't need to be compiled for each project. Probably one for a later PR.

If you meant sharing bower_components folders, yes it is possible. The only reason I did not do that is due to the fact that bower uses flat dependencies. In case two exercises use different versions of the same dependency, this could result in problems. On the other hand, the probability of that happening is probably low.

However, that would probably not result in significant improvements over time - after the first download and compilation of a single exercise, the whole thing is cached, so it would not recompile in subsequent builds.

In any case, let me know if you'd prefer me to change to that model.

@lpil
Copy link
Sponsor Member

lpil commented Mar 17, 2017

I think the current approach is good :)

@icyrockcom
Copy link
Contributor Author

@paf31 Do you think this can be merged at this point or do you suggest any additional changes?

@paf31 paf31 merged commit c8142f9 into exercism:master Mar 21, 2017
@paf31
Copy link
Contributor

paf31 commented Mar 21, 2017

Thanks!

@icyrockcom
Copy link
Contributor Author

That was quick, thanks @paf31!

@icyrockcom icyrockcom deleted the travis branch March 31, 2017 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants