-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
triangle: adding a new scalene test for two smaller sides equal #1894
Conversation
Adding a new test for scalene(sides) function and renaming another test to match the new test.
New merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for the PR!
Most test cases in the Python track are derived from the problem-specifications repository. You've identified a gap in the tests, so normally I would recommend adding the test to the canonical data first before it is added here. However, since that repository is currently frozen, we can add this test as a track-specific test for now.
Please address the following, and we'll be good to go:
- Revert name change on the existing test; the name comes from the canonical data, and we try to follow that when reasonable
- Rename your new test to something descriptive of why that test is different than
two_sides_are_equal
. I've suggested a change below; if you have something better you don't need to use my suggestion exactly
I would also recommend creating an issue in the [problem specifications] repository so that when the freeze is over, this test can be added there.
add track-specific test Co-Authored-By: Corey McCandless <cmccandless@users.noreply.github.com>
Co-Authored-By: Corey McCandless <cmccandless@users.noreply.github.com>
Merged; thanks for working on this! |
Adding a new test for scalene(sides) function and renaming another test to match the new test. Current tests for scalene(sides) function can be hacked by this code:
while the new test not.