Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making-the-grade: adjusting docstring indentation #3002

Closed
wants to merge 1 commit into from
Closed

making-the-grade: adjusting docstring indentation #3002

wants to merge 1 commit into from

Conversation

imrehg
Copy link

@imrehg imrehg commented Apr 10, 2022

Minor stuff, just to have consistency in the looks.

@github-actions

This comment was marked as resolved.

@BethanyG
Copy link
Member

Hi @imrehg 👋🏽

Thanks so much for submitting this PR. Normally, I'd accept it but we have someone working on the docsttings as a group (see issue #2974 for discussion), and I think the change is better left to them because they are making other changes as well.
As such, I am going to close this PR.

@Metallifax - FYI for this indentation issue - and let me know if you have any questions or issues, or are no longer working on docstrings. Thanks!

@BethanyG BethanyG closed this Apr 10, 2022
@Metallifax
Copy link
Contributor

@BethanyG I have a branch that shows my current progress for the cleanup effort if your'e interested in having a peek. Pydocstyle sees the same indentation problem on my end, it was just a matter of getting that far down the list. I'm hoping to submit the pull request on it either sometime tonight or tomorrow and we can go over questions I have in the review stage if that works for you. Regards.

@imrehg imrehg deleted the making-the-grade-formatting branch April 16, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants