Dig Deeper for Nth Prime

[safwansamsudeen]

No description provided.

[BethanyG]

@Kiran1689, please see my comments on #3456.

[safwansamsudeen]

@BethanyG just to give you a heads up - it's been a few months.

[BethanyG]

@safwansamsudeen - Thanks. I have some work I need to wrap up on tooling, but will review this in the next week.

[BethanyG]

Thank you for this. Apologies for the delay in reviewing/approving.

[safwansamsudeen]

I recently realized while reviewing another person's solution that some bits of this code weren't great, though. This:

from itertools import islice, count

def is_prime(n):
    return not any(n % k == 0 for k in range(2, int(n ** 0.5) + 1))

def prime(number):
    if number == 0:
        raise ValueError('there is no zeroth prime')
    gen = islice(filter(is_prime, count(2)), number)
    for _ in range(number - 1): next(gen)
    return next(gen)

is much better off as:

from itertools import count

def is_prime(n):
    return all(n % k != 0 for k in range(2, int(n ** 0.5) + 1))

def prime(number):
    if number == 0:
        raise ValueError('there is no zeroth prime')
    gen = filter(is_prime, count(2))
    for _ in range(number - 1): next(gen)
    return next(gen)

Can I submit another PR, or shall we leave it as is?

[BethanyG]

Let's leave it for now, plz. I have some track maintenance planned for EOM/ beginning of year, and we can address it then. 😄

[safwansamsudeen]

@BethanyG did you address it? Or shall I open a PR?