Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pascals-triangle: add parameters to exercise placeholder #705

Merged
merged 3 commits into from
Oct 6, 2017
Merged

pascals-triangle: add parameters to exercise placeholder #705

merged 3 commits into from
Oct 6, 2017

Conversation

parinporecha
Copy link
Contributor

@parinporecha parinporecha commented Oct 4, 2017 •
edited by ilya-khadykin
Loading

Fixes #606

@parinporecha parinporecha mentioned this pull request Oct 4, 2017
Closed
ilya-khadykin
ilya-khadykin suggested changes Oct 4, 2017
View reviewed changes
Copy link
Contributor

@ilya-khadykin ilya-khadykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I left a comment for discussion

exercises/pascals-triangle/pascals_triangle.py Outdated
pass


def is_triangle():
def is_triangle(triangle):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe more appropriate name for the parameter will be triangle_rows_list or something similar.
triangle can be mistaken by an instance of class Triangle for example.
What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That certainly makes sense. I've updated the parameter name.

@ilya-khadykin ilya-khadykin merged commit 9d0e419 into exercism:master Oct 6, 2017
@ilya-khadykin
Copy link
Contributor

Thanks for your contribution, @parinporecha

This is just for your considiration for future PRs - it's a good practice to squash your commits https://github.com/exercism/docs/blob/master/contributing/git-basics.md#squashing. It isn't a big deal since I can do it myself, but it would be awesome to just click on 'Merge pull request' button 😃

ErikSchierboom added a commit to ErikSchierboom/python that referenced this pull request Jan 21, 2021
@yawpitch @khoivan88
@DavidGerva @aldraco @paparomeo @BethanyG @ErikSchierboom
Concept extraction / references mega merge (exercism#700)
2b7df9e 
* Create common working area

* Extract Concepts from v2 exercise: reverse-string  (exercism#657)

* Create reverse-string.md

* Update reverse-string.md

* Add Concepts from v2 exercise: variable-length-quantity (exercism#503)

* Add first concepts group

* Improved concepts as per PR review

* Adds concept from binary-search-tree (exercism#501)

* Add initial list (exercism#463)

First pass concepts for `allergies` to address exercism#460

* Initial list of concepts (exercism#462)

First pass list of concepts to address exercism#459

* Add Concepts for v2 exercise: phone-number (exercism#420)

* Add phone-number Python concepts

* Small update to index access and slice topics.

* Add notes from review.
 - more information about classes, inheritance
 - flesh out privacy, public and non-public
 - clarify wording around iterables and index/slice access

* One more note about brackets and strings.

* Add Concepts for v2 exercise: hamming (exercism#418)

* Add concepts for hamming

* Add note about tuple unpacking.

* Add notes about polymorphism, builtins, and dunder methods.

* Some whitespace fixes.

* [WIP] `clock` exercise concepts. (exercism#395)

* Extract Concepts from v2 exercise: markdown (exercism#540)

* Initial commit for markdown exercise concepts.

* Concept starter for markdown

* Added detail to Markdown concepts

* Final edits before harmonization

Final Markdown edits before we merge and harmonize.

* Add Concepts for v2 exercise: matrix (exercism#416)

* `matrix` exercise concepts (issue exercism#386)

First pass of concepts for `matrix ` exercise in python.  Pretty sure this is too detailed, but wanted to get something for review before proceeding with additional exercises.

* Edits to better match exercism#290 Formatting

Edited concepts to better match the formatting of issue exercism#290

* Typo correction

* added title

* Extract Concepts from v2 exercise: rna-transcription (exercism#520)

* Beginning of Concepts for rna-transcription

* More detailed concepts for rna-trranscription

More detailed concepts for rna-transcription exrcise.

* Added title

* Extract Concepts from v2 exercise: robot-simulator (exercism#538)

* Beginning of concepts for robot-simulator.

* WIP Concepts

* Additional detail for concepts

* Detail third pass

Third pass on adding concept detail.

* Additional detail for concepts.

* Edits per PR Feedback

Numerous spelling corrections.  Additional edits to address comments from last review.

* [WIP] Concept implementation instructions (exercism#665)

* Adds instructions for exercise implementation

* Adds correction as per PR reviews

* Harmonize, part 1 (exercism#705)

* fix relative links in references/README.md

* First pass at harmonization

Shifts all documents to a common format, adds minimal link tagging to
the "concept" currently listed in each file. These will really need
multiple more passes, as they diverge from each other even when
describing the same topic. Many extraneous topics have crept in, added
in an "aspirational" fashion to the exercises; we may need to trim some
of that.

* Pulling in examples from BethanyG

* [WIP] Extracted concept unification (exercism#793)

* Unification of extracted concepts

* Typos and duplicates remove

* Duplicates concept unification

* Concepts have now links to original file

* Update languages/reference/README.md

Co-Authored-By: Erik Schierboom <erik_schierboom@hotmail.com>

Co-authored-by: khoivan88 <33493502+khoivan88@users.noreply.github.com>
Co-authored-by: David G <davidgerva@gmail.com>
Co-authored-by: Ashley Drake <a.l.drake713@gmail.com>
Co-authored-by: Pedro Romano <pedro@paparomeo.net>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
ErikSchierboom added a commit to ErikSchierboom/python that referenced this pull request Jan 22, 2021
@yawpitch @khoivan88
@DavidGerva @aldraco @paparomeo @BethanyG @ErikSchierboom
Concept extraction / references mega merge (exercism#700)
3409943 
* Create common working area

* Extract Concepts from v2 exercise: reverse-string  (exercism#657)

* Create reverse-string.md

* Update reverse-string.md

* Add Concepts from v2 exercise: variable-length-quantity (exercism#503)

* Add first concepts group

* Improved concepts as per PR review

* Adds concept from binary-search-tree (exercism#501)

* Add initial list (exercism#463)

First pass concepts for `allergies` to address exercism#460

* Initial list of concepts (exercism#462)

First pass list of concepts to address exercism#459

* Add Concepts for v2 exercise: phone-number (exercism#420)

* Add phone-number Python concepts

* Small update to index access and slice topics.

* Add notes from review.
 - more information about classes, inheritance
 - flesh out privacy, public and non-public
 - clarify wording around iterables and index/slice access

* One more note about brackets and strings.

* Add Concepts for v2 exercise: hamming (exercism#418)

* Add concepts for hamming

* Add note about tuple unpacking.

* Add notes about polymorphism, builtins, and dunder methods.

* Some whitespace fixes.

* [WIP] `clock` exercise concepts. (exercism#395)

* Extract Concepts from v2 exercise: markdown (exercism#540)

* Initial commit for markdown exercise concepts.

* Concept starter for markdown

* Added detail to Markdown concepts

* Final edits before harmonization

Final Markdown edits before we merge and harmonize.

* Add Concepts for v2 exercise: matrix (exercism#416)

* `matrix` exercise concepts (issue exercism#386)

First pass of concepts for `matrix ` exercise in python.  Pretty sure this is too detailed, but wanted to get something for review before proceeding with additional exercises.

* Edits to better match exercism#290 Formatting

Edited concepts to better match the formatting of issue exercism#290

* Typo correction

* added title

* Extract Concepts from v2 exercise: rna-transcription (exercism#520)

* Beginning of Concepts for rna-transcription

* More detailed concepts for rna-trranscription

More detailed concepts for rna-transcription exrcise.

* Added title

* Extract Concepts from v2 exercise: robot-simulator (exercism#538)

* Beginning of concepts for robot-simulator.

* WIP Concepts

* Additional detail for concepts

* Detail third pass

Third pass on adding concept detail.

* Additional detail for concepts.

* Edits per PR Feedback

Numerous spelling corrections.  Additional edits to address comments from last review.

* [WIP] Concept implementation instructions (exercism#665)

* Adds instructions for exercise implementation

* Adds correction as per PR reviews

* Harmonize, part 1 (exercism#705)

* fix relative links in references/README.md

* First pass at harmonization

Shifts all documents to a common format, adds minimal link tagging to
the "concept" currently listed in each file. These will really need
multiple more passes, as they diverge from each other even when
describing the same topic. Many extraneous topics have crept in, added
in an "aspirational" fashion to the exercises; we may need to trim some
of that.

* Pulling in examples from BethanyG

* [WIP] Extracted concept unification (exercism#793)

* Unification of extracted concepts

* Typos and duplicates remove

* Duplicates concept unification

* Concepts have now links to original file

* Update languages/reference/README.md

Co-Authored-By: Erik Schierboom <erik_schierboom@hotmail.com>

Co-authored-by: khoivan88 <33493502+khoivan88@users.noreply.github.com>
Co-authored-by: David G <davidgerva@gmail.com>
Co-authored-by: Ashley Drake <a.l.drake713@gmail.com>
Co-authored-by: Pedro Romano <pedro@paparomeo.net>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
ErikSchierboom added a commit to ErikSchierboom/python that referenced this pull request Jan 26, 2021
@yawpitch @khoivan88
@DavidGerva @aldraco @paparomeo @BethanyG @ErikSchierboom
Concept extraction / references mega merge (exercism#700)
546b2ff 
* Create common working area

* Extract Concepts from v2 exercise: reverse-string  (exercism#657)

* Create reverse-string.md

* Update reverse-string.md

* Add Concepts from v2 exercise: variable-length-quantity (exercism#503)

* Add first concepts group

* Improved concepts as per PR review

* Adds concept from binary-search-tree (exercism#501)

* Add initial list (exercism#463)

First pass concepts for `allergies` to address exercism#460

* Initial list of concepts (exercism#462)

First pass list of concepts to address exercism#459

* Add Concepts for v2 exercise: phone-number (exercism#420)

* Add phone-number Python concepts

* Small update to index access and slice topics.

* Add notes from review.
 - more information about classes, inheritance
 - flesh out privacy, public and non-public
 - clarify wording around iterables and index/slice access

* One more note about brackets and strings.

* Add Concepts for v2 exercise: hamming (exercism#418)

* Add concepts for hamming

* Add note about tuple unpacking.

* Add notes about polymorphism, builtins, and dunder methods.

* Some whitespace fixes.

* [WIP] `clock` exercise concepts. (exercism#395)

* Extract Concepts from v2 exercise: markdown (exercism#540)

* Initial commit for markdown exercise concepts.

* Concept starter for markdown

* Added detail to Markdown concepts

* Final edits before harmonization

Final Markdown edits before we merge and harmonize.

* Add Concepts for v2 exercise: matrix (exercism#416)

* `matrix` exercise concepts (issue exercism#386)

First pass of concepts for `matrix ` exercise in python.  Pretty sure this is too detailed, but wanted to get something for review before proceeding with additional exercises.

* Edits to better match exercism#290 Formatting

Edited concepts to better match the formatting of issue exercism#290

* Typo correction

* added title

* Extract Concepts from v2 exercise: rna-transcription (exercism#520)

* Beginning of Concepts for rna-transcription

* More detailed concepts for rna-trranscription

More detailed concepts for rna-transcription exrcise.

* Added title

* Extract Concepts from v2 exercise: robot-simulator (exercism#538)

* Beginning of concepts for robot-simulator.

* WIP Concepts

* Additional detail for concepts

* Detail third pass

Third pass on adding concept detail.

* Additional detail for concepts.

* Edits per PR Feedback

Numerous spelling corrections.  Additional edits to address comments from last review.

* [WIP] Concept implementation instructions (exercism#665)

* Adds instructions for exercise implementation

* Adds correction as per PR reviews

* Harmonize, part 1 (exercism#705)

* fix relative links in references/README.md

* First pass at harmonization

Shifts all documents to a common format, adds minimal link tagging to
the "concept" currently listed in each file. These will really need
multiple more passes, as they diverge from each other even when
describing the same topic. Many extraneous topics have crept in, added
in an "aspirational" fashion to the exercises; we may need to trim some
of that.

* Pulling in examples from BethanyG

* [WIP] Extracted concept unification (exercism#793)

* Unification of extracted concepts

* Typos and duplicates remove

* Duplicates concept unification

* Concepts have now links to original file

* Update languages/reference/README.md

Co-Authored-By: Erik Schierboom <erik_schierboom@hotmail.com>

Co-authored-by: khoivan88 <33493502+khoivan88@users.noreply.github.com>
Co-authored-by: David G <davidgerva@gmail.com>
Co-authored-by: Ashley Drake <a.l.drake713@gmail.com>
Co-authored-by: Pedro Romano <pedro@paparomeo.net>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
ErikSchierboom added a commit to ErikSchierboom/python that referenced this pull request Jan 27, 2021
@yawpitch @khoivan88
@DavidGerva @aldraco @paparomeo @BethanyG @ErikSchierboom
Concept extraction / references mega merge (exercism#700)
39fffb5 
* Create common working area

* Extract Concepts from v2 exercise: reverse-string  (exercism#657)

* Create reverse-string.md

* Update reverse-string.md

* Add Concepts from v2 exercise: variable-length-quantity (exercism#503)

* Add first concepts group

* Improved concepts as per PR review

* Adds concept from binary-search-tree (exercism#501)

* Add initial list (exercism#463)

First pass concepts for `allergies` to address exercism#460

* Initial list of concepts (exercism#462)

First pass list of concepts to address exercism#459

* Add Concepts for v2 exercise: phone-number (exercism#420)

* Add phone-number Python concepts

* Small update to index access and slice topics.

* Add notes from review.
 - more information about classes, inheritance
 - flesh out privacy, public and non-public
 - clarify wording around iterables and index/slice access

* One more note about brackets and strings.

* Add Concepts for v2 exercise: hamming (exercism#418)

* Add concepts for hamming

* Add note about tuple unpacking.

* Add notes about polymorphism, builtins, and dunder methods.

* Some whitespace fixes.

* [WIP] `clock` exercise concepts. (exercism#395)

* Extract Concepts from v2 exercise: markdown (exercism#540)

* Initial commit for markdown exercise concepts.

* Concept starter for markdown

* Added detail to Markdown concepts

* Final edits before harmonization

Final Markdown edits before we merge and harmonize.

* Add Concepts for v2 exercise: matrix (exercism#416)

* `matrix` exercise concepts (issue exercism#386)

First pass of concepts for `matrix ` exercise in python.  Pretty sure this is too detailed, but wanted to get something for review before proceeding with additional exercises.

* Edits to better match exercism#290 Formatting

Edited concepts to better match the formatting of issue exercism#290

* Typo correction

* added title

* Extract Concepts from v2 exercise: rna-transcription (exercism#520)

* Beginning of Concepts for rna-transcription

* More detailed concepts for rna-trranscription

More detailed concepts for rna-transcription exrcise.

* Added title

* Extract Concepts from v2 exercise: robot-simulator (exercism#538)

* Beginning of concepts for robot-simulator.

* WIP Concepts

* Additional detail for concepts

* Detail third pass

Third pass on adding concept detail.

* Additional detail for concepts.

* Edits per PR Feedback

Numerous spelling corrections.  Additional edits to address comments from last review.

* [WIP] Concept implementation instructions (exercism#665)

* Adds instructions for exercise implementation

* Adds correction as per PR reviews

* Harmonize, part 1 (exercism#705)

* fix relative links in references/README.md

* First pass at harmonization

Shifts all documents to a common format, adds minimal link tagging to
the "concept" currently listed in each file. These will really need
multiple more passes, as they diverge from each other even when
describing the same topic. Many extraneous topics have crept in, added
in an "aspirational" fashion to the exercises; we may need to trim some
of that.

* Pulling in examples from BethanyG

* [WIP] Extracted concept unification (exercism#793)

* Unification of extracted concepts

* Typos and duplicates remove

* Duplicates concept unification

* Concepts have now links to original file

* Update languages/reference/README.md

Co-Authored-By: Erik Schierboom <erik_schierboom@hotmail.com>

Co-authored-by: khoivan88 <33493502+khoivan88@users.noreply.github.com>
Co-authored-by: David G <davidgerva@gmail.com>
Co-authored-by: Ashley Drake <a.l.drake713@gmail.com>
Co-authored-by: Pedro Romano <pedro@paparomeo.net>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
@PaulT89 PaulT89 mentioned this pull request Jun 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-khadykin ilya-khadykin ilya-khadykin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@parinporecha @ilya-khadykin