Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create test script #1

Closed
kytrinyx opened this issue Feb 27, 2014 · 13 comments · Fixed by #19
Closed

Create test script #1

kytrinyx opened this issue Feb 27, 2014 · 13 comments · Fixed by #19

Comments

@kytrinyx
Copy link
Member

Verify that each test suite has an example file that passes it.
@kytrinyx kytrinyx mentioned this issue Feb 27, 2014
Closed
@fluxusfrequency
Copy link
Contributor

I'm working on this.
Question: does this mean that they should pass with the tests after the first skipped? Or all unskipped? If the latter, gigasecond will break.

Also, house's test suite is crazy now.

@fluxusfrequency
Copy link
Contributor

Any idea what happened to OCR numbers? The example is broken, and so is my (previously passing) solution.

@kytrinyx
Copy link
Member Author

kytrinyx commented May 2, 2014

The test suites should pass with everything unskipped.

I haven't really looked at house and OCR lately. I'll dig around in the history a bit.

@kytrinyx
Copy link
Member Author

kytrinyx commented May 2, 2014

Update: There was a discussion about house here: exercism/haskell#6

@kytrinyx
Copy link
Member Author

kytrinyx commented May 2, 2014

I don't see any changes to OCR numbers in the last 5 months. No idea what's going on.

@fluxusfrequency
Copy link
Contributor

Ok, my editor was set to trim whitespace automatically on save, and that broke everything.
It's actually passing. My mistake.

@fluxusfrequency
Copy link
Contributor

As for house, the old version I have led you to build an implementation. It seems like the new test pushes you to copy/paste it and have a method that just returns the whole rhyme. Is there more to this @sjakobi and @etrepum?

@fluxusfrequency
Copy link
Contributor

Cool, I've gotten through them all now, but the fixes I made are on my machine at work. I'll push them up on Monday. There were only two that were broken.

@sjakobi
Copy link

sjakobi commented May 3, 2014

As for house, the old version I have led you to build an implementation. It seems like the new test pushes you to copy/paste it and have a method that just returns the whole rhyme. Is there more to this @sjakobi and @etrepum?

The tests for the Python and Haskell implementations of the house exercise were kept this simple so students could come up with all the implementation details on their own. So far I haven't seen any solutions that would just return a string literal.

@fluxusfrequency
Copy link
Contributor

Interesting. My style of testing generally involves the "dumbest" solution first, so I totally would have copy/pasted. I kind of liked being led to an implementation by the old Ruby test. Still, I can see the point of letting people implement it themselves. It is a cool pattern to try to reduce into a program.

fluxusfrequency added a commit to fluxusfrequency/xruby that referenced this issue May 5, 2014
@fluxusfrequency
fix test and example pairs for food-chain, nucleotide-count, and phon…
9366e45 
…e-number, fixes exercism#1
@fluxusfrequency fluxusfrequency mentioned this issue May 5, 2014
Merged
@fluxusfrequency
Copy link
Contributor

FWIW, I just saw a literal solution to House in Ruby.

http://exercism.io/submissions/1af1f26abb5bf1cd7dd58dcf

@sjakobi
Copy link

sjakobi commented May 7, 2014

Maybe we should just add a note to the README-md or -yml?

@kytrinyx
Copy link
Member Author

kytrinyx commented May 7, 2014

It's a good starting point. Next: refactor.

I don't think we need to add any comments, let people discuss it with the person who posted it.

fluxusfrequency pushed a commit to fluxusfrequency/xruby that referenced this issue May 9, 2014
@kytrinyx
Configure Travis build. Fixes exercism#1
ec8c439
kytrinyx pushed a commit that referenced this issue Oct 9, 2014
@fluxusfrequency
fix test and example pairs for food-chain, nucleotide-count, and phon…
54a3038 
…e-number, fixes #1
gchan pushed a commit to gchan/xruby that referenced this issue Oct 18, 2016
@kytrinyx
Remove reference to other problem. Fixes exercism#1.
f33df0e 
The problems `simple-linked-list` and `linked-list` should be
independent of each other.
Insti pushed a commit that referenced this issue Aug 21, 2018
@kevinsamoei
Merge pull request #1 from exercism/review_841
1f877a6 
Fix test failing after bookkeeping.md file is removed.
@emcoding emcoding mentioned this issue Jun 10, 2019
Closed
emcoding added a commit that referenced this issue Jul 23, 2019
@emcoding
Move flatten array up in the track
6e2bb5c 
See #970
Resistor Color (#1 in the series) is added to the track as a side exercise, unlocked by Hello World.
The main reason to add the exercise was to have a replacement for Flatten Array. 
Flatten Array is not a nice exercise as an introduction to the track, because it's either just using the `Array#flatten` or reimplementing this built in method. 
Let's see if people have fun with if we move it to a later position, and if not, we can remove it from the track alltogether.
@emcoding emcoding mentioned this issue Jul 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix test and example pairs for food-chain, nucleotide-count, and phone-n... fluxusfrequency/xruby
3 participants
@kytrinyx @sjakobi @fluxusfrequency