Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Custom Set tests #348

Closed
IanWhitney opened this issue May 16, 2016 · 1 comment · Fixed by #383
Closed

Changes to Custom Set tests #348

IanWhitney opened this issue May 16, 2016 · 1 comment · Fixed by #383
Labels

Comments

@IanWhitney
Copy link

We recently rewrote the test suite for Custom Set. Since this track implements Custom Set, please take a look at the new custom_set.json file and see if your track should update its implementation or tests.

The new test suite reorders tests so that students can get to green quickly. It also reduces the number of tests so that students can focus on solving the interesting edge cases.

More details on this change are available in the pull request

@kotp
Copy link
Member

kotp commented May 16, 2016

Thanks @IanWhitney Been monitoring those discussions.

kotp added a commit that referenced this issue Jun 22, 2016
The custom-set exercise is generated using data from x-common
repository.

fixes #365
fixes #348
references exercism/problem-specifications#257
kotp added a commit that referenced this issue Jun 22, 2016
The custom-set exercise is generated using data from x-common
repository.

fixes #365
fixes #348
references exercism/problem-specifications#257
kotp added a commit that referenced this issue Jun 23, 2016
The custom-set exercise is generated using data from x-common
repository.

fixes #365
fixes #348
references exercism/problem-specifications#257
kotp added a commit that referenced this issue Jun 23, 2016
The custom-set exercise is generated using data from x-common
repository.

fixes #365
fixes #348
references exercism/problem-specifications#257
kotp added a commit that referenced this issue Jun 23, 2016
The custom-set exercise is generated using data from x-common
repository.

fixes #365
fixes #348
references exercism/problem-specifications#257
@kotp kotp added the ready label Jun 23, 2016
kotp added a commit that referenced this issue Jun 24, 2016
The custom-set exercise is generated using data from x-common
repository.

fixes #365
fixes #348
references exercism/problem-specifications#257
kotp added a commit that referenced this issue Jun 26, 2016
The custom-set exercise is generated using data from x-common
repository.

fixes #365
fixes #348
references exercism/problem-specifications#257
kotp added a commit that referenced this issue Jun 28, 2016
The custom-set exercise is generated using data from x-common
repository.

fixes #365
fixes #348
references exercism/problem-specifications#257
kotp added a commit that referenced this issue Jun 28, 2016
The custom-set exercise is generated using data from x-common
repository.

fixes #365
fixes #348
references exercism/problem-specifications#257
kotp added a commit that referenced this issue Jun 30, 2016
The custom-set exercise is generated using data from x-common
repository.

fixes #365
fixes #348
references exercism/problem-specifications#257
kotp added a commit that referenced this issue Jul 1, 2016
The custom-set exercise is generated using data from x-common
repository.

fixes #365
fixes #348
references exercism/problem-specifications#257
@kotp kotp closed this as completed in #383 Jul 14, 2016
gchan pushed a commit to gchan/xruby that referenced this issue Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants