Tests for Robot Name not strict enough

[vitoreiji]

The robot-name/README.md specification states that robot name should conform to a format like

RX837 or BC811

That is, two letters and then three digits. Yet, the code that tests for this pattern is /\w{2}\d{3}/, which allows a string such as 0.2542346345724565 to pass the test.
I've checked how the tests for this exercise are implemented in a few other languages (perl5, haskell, lua) and they do enforce the two-letters-three-digits format, mostly by using [a-zA-Z] instead of \w.
I believe this is important because the tests should formalize the general idea provided by the README, where the specification is really not very specific, prompting learners to submit code that is unchallenging like my first submission to this exercise.

[kytrinyx]

Nice catch. Would you be willing to submit a patch for the test suite? https://github.com/exercism/xruby

[vitoreiji]

I just submitted a pull request addressing this issue. Let me know if there's anything I should improve before it can be merged.

[cbojar]

Don't we also need begin and end delimiters so it doesn't accept something like "asdsdvfverAD234dsghs./,!"?

[kytrinyx]

Yeah, it would be good to have tests agains that case.

[vitoreiji]

Hey, thanks!
I comitted the suggested changes to my fork. Not sure how to proceed now, this is my first time updating a pull request.
Cheers!

[kytrinyx]

If you submitted changes to your fork, the PR will automatically be updated. Thanks!

[britishtea]

I think this issue can be closed, since #36 is closed as well.

[kytrinyx]

Yepp, good catch, thanks.