Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: Typo in test case #1615

Closed
wants to merge 1 commit into from
Closed

Conversation

meatball133
Copy link
Member

No description provided.

@meatball133 meatball133 added the x:rep/small Small amount of reputation label Dec 29, 2023
@kotp
Copy link
Member

kotp commented Dec 29, 2023

Is this already in place and merged from #1613 ?

@meatball133
Copy link
Member Author

Yeah, thought there was no other pr about it. Since the user that opened that pr also opened a post on the forum without mentioning that they had opened a pr.

@vmyts539
Copy link
Contributor

@meatball133, welp, sorry about that, It was a surprise for me that it was reopened and merged as I saw that it has closed automatically and you responded on the forum that you'll take it afterward so I thought that mine would just stay as it is

@kotp
Copy link
Member

kotp commented Dec 30, 2023

@meatball133, welp, sorry about that, It was a surprise for me that it was reopened and merged as I saw that it has closed automatically and you responded on the forum that you'll take it afterward so I thought that mine would just stay as it is

I think it is just because message of "You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch." is late since it shows after you create the PR, and if you create the PR using command line tools, it is even more likely you will not see it in a timely manner.

So, @vmyts539 , more of a "Our Fault" problem than anything you did or did not do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:rep/small Small amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants