Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add topics to those exercises missing them #558

Merged
merged 1 commit into from
Jun 21, 2018

Conversation

coriolinus
Copy link
Member

Contributes to #543

"topics": null
"topics": [
"ascii",
"regular_expressions",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not necessarily, but I don't have grounds for asking this to be removed because I don't think there are clear standards on what topics should be put. Should a topic be put if it is possible that a solution might use it? Or should it only be put if a solution must use it (perhaps because the tests require it), etc.? Or are we supposed to exercise judgment and include a topic if we think any reasonable solution would use it? But what constitutes reasonable? etc.

We shouldn't discuss this for too long. Long enough to figure out what questions we have, then we should present these questions to someone who would know. Who would know?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with all of your comments; topics are too underspecified for my taste. Perhaps actual usage on exercism v2 will help us determine some more concrete guidelines for topic selection.

I added it as a topic as a recommendation to students, on the assumption that students will see the topics before beginning the exercise. My own implementation doesn't use regular expressions, and it was much more complicated than the example, which does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants