-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dockerfile updated #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now build! First step towards getting a working Docker image.
Dockerfile
Outdated
# FROM gradle:jdk-alpine | ||
|
||
ARG SBT_VERSION=1.2.8 | ||
### Taken from: https://github.com/mozilla/docker-sbt | ||
|
||
ARG OPENJDK_TAG=8u232 | ||
FROM openjdk:${OPENJDK_TAG} | ||
|
||
ARG SBT_VERSION=1.4.5 | ||
|
||
# Install sbt | ||
RUN \ | ||
mkdir /working/ && \ | ||
cd /working/ && \ | ||
curl -L -o sbt-$SBT_VERSION.deb https://dl.bintray.com/sbt/debian/sbt-$SBT_VERSION.deb && \ | ||
dpkg -i sbt-$SBT_VERSION.deb && \ | ||
rm sbt-$SBT_VERSION.deb && \ | ||
apt-get update && \ | ||
apt-get install sbt && \ | ||
cd && \ | ||
rm -r /working/ && \ | ||
sbt sbtVersion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not directly use the mozilla/sbt
image?
FROM mozilla/sbt:8u232_1.4.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tried to address both points, it should work even better now :)
Dockerfile
Outdated
#RUN sbt -Dsbt.ivy.home=.ivy2 -Dsbt.global.base=.sbt/1.0 -Dsbt.boot.directory=.sbt/boot test | ||
RUN mkdir -p /opt/scala-test-runner | ||
RUN mkdir -p /opt/scala-test-runner/lib | ||
|
||
#RUN cp /home/gradle/target/scala-2.12/*.jar /opt/scala-test-runner/lib | ||
COPY bin/run.sh /opt/scala-test-runner/bin/ | ||
# RUN sbt compile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be uncommented at some point at this compiles the actual test runner.
1c4d4da
to
4da9f38
Compare
@MeerKatDev This now is almost fully functional. There are three remaining TODOs that I'll create issues for. |
No description provided.