Add exercise 'square-root' #245
Conversation
| let | ||
| fun recurse guess = | ||
| let | ||
| val estimate = (guess * (guess + 1) + radicand) div (2 * guess) |
There was a problem hiding this comment.
Can you provide a brief description or reference for the methodology which is used to compute the square root (as a docstring)? This looks a bit like Heron's method, but possibly slightly adapted to the integer world?
There was a problem hiding this comment.
Comment added. We implement Heron's method using integer arithmetic, rounding the estimate to the nearest natural number.
There was a problem hiding this comment.
OK sounds reasonable. I didn't rigorously check it though, the tests pass and I assume that you made sure some kind of correctness in general?
If yes I will merge it.
There was a problem hiding this comment.
I have tested radicand values 1 .. 10000
My V implementation also works for 0, but that isn't important as the instructions exclude 0.
| let | ||
| fun recurse guess = | ||
| let | ||
| val estimate = (guess * (guess + 1) + radicand) div (2 * guess) |
There was a problem hiding this comment.
OK sounds reasonable. I didn't rigorously check it though, the tests pass and I assume that you made sure some kind of correctness in general?
If yes I will merge it.
No description provided.