Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update binary to return Optionals #68

Merged
merged 1 commit into from Sep 16, 2015

Conversation

masters3d
Copy link
Contributor

@hankturowski
Copy link
Contributor

Your Travis integration is an amazing improvement.

hankturowski added a commit that referenced this pull request Sep 16, 2015
update binary to return Optionals
@hankturowski hankturowski merged commit caac989 into exercism:master Sep 16, 2015
@hankturowski
Copy link
Contributor

I like this update a lot. We should do more with optionals.

@masters3d
Copy link
Contributor Author

Thanks! Travis is cool. takes about 2-3 minutes to run though, not sure if that is normal.
I was debating between throwing or optionals but I am not a fan of making all the callers have to use try try? for everything.
http://ericasadun.com/2015/07/29/nils-vs-throws-in-swiftlang-part-ii/

@hankturowski
Copy link
Contributor

I think that 2-3 minutes is a small price to pay for the added layer of protection. With the test running sequentially, I'm not surprised it takes that long.

I agree with you on try?. We should look through the exercises and see which ones might be good candidates for try blocks. Maybe we set up some specific error types to be returned? I kind of like the idea of an exercise that defines some things ahead of time and expects the user to conform. Like they're extending an existing system and can't touch the existing error types.

Maybe we can push a starter exercise.swift file with a predefined class and set of errors, then ask the user to extend it without touching the existing code.

@kytrinyx
Copy link
Member

Travis might speed up if we configure it with sudo: false so that it uses containerized builds.

@masters3d
Copy link
Contributor Author

i did try sudo: false on a test branch but not much improvement. I can live with 2-3 mins wait per pr. ;)

masters3d added a commit that referenced this pull request Apr 7, 2016
Added `sudo: false`
#68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants