Address #250 Normalise topics

[Roshanjossey]

Fix topics for diamond, two-buckets and variable-length-quantity

[pacman-bot]

	8 Messages
📖	exercises/atbash-cipher/atbash-cipher.example.ts#L2 - Type string trivially inferred from a string literal, remove type annotation. (@typescript-eslint/no-inferrable-types)
📖	exercises/atbash-cipher/atbash-cipher.example.ts#L3 - Type string trivially inferred from a string literal, remove type annotation. (@typescript-eslint/no-inferrable-types)
📖	exercises/beer-song/beer-song.example.ts#L28 - Type number trivially inferred from a number literal, remove type annotation. (@typescript-eslint/no-inferrable-types)
📖	exercises/clock/clock.example.ts#L5 - Type number trivially inferred from a number literal, remove type annotation. (@typescript-eslint/no-inferrable-types)
📖	exercises/pangram/pangram.example.ts#L7 - Type string trivially inferred from a string literal, remove type annotation. (@typescript-eslint/no-inferrable-types)
📖	exercises/pythagorean-triplet/pythagorean-triplet.example.ts#L35 - Type number trivially inferred from a number literal, remove type annotation. (@typescript-eslint/no-inferrable-types)
📖	exercises/robot-simulator/robot-simulator.example.ts#L5 - Type number trivially inferred from a number literal, remove type annotation. (@typescript-eslint/no-inferrable-types)
📖	exercises/robot-simulator/robot-simulator.example.ts#L5 - Type string trivially inferred from a string literal, remove type annotation. (@typescript-eslint/no-inferrable-types)

Generated by 🚫 Danger

[SleeplessByte]

Don't mind these warnings :)

[Roshanjossey]

Hi @SleeplessByte, I see that the errors are caused by explicitly adding types when it's not necessary.

Shall I submit a pull request to address this?

[SleeplessByte]

We probably want to fine-tune @typescript-eslint/no-inferrable-types first. I'll accept a PR to add these lines https://github.com/exercism/javascript-analyzer/blob/master/.eslintrc#L42-L46, which will solve most of them.

[Roshanjossey]

Got it.

Should this change be made in https://github.com/exercism/typescript-analyzer/blob/master/.eslintrc or individual .eslintrc in project directories? Is there a mechanism by which these are synced?

[Roshanjossey]

Also, even with the change you suggested

add these lines https://github.com/exercism/javascript-analyzer/blob/master/.eslintrc#L42-L46,

We need to fix these as these are properties, won't we?

This is my reference https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-inferrable-types.md

[SleeplessByte]

That's right. These:

typescript/exercises/atbash-cipher/atbash-cipher.example.ts

Line 2 in bc01a90

private alphabet: string = "abcdefghijklmnopqrstuvwxyz"

typescript/exercises/atbash-cipher/atbash-cipher.example.ts

Line 3 in bc01a90

private numbers: string = "0123456789"

need to be fixed, but these

typescript/exercises/robot-simulator/robot-simulator.example.ts

Line 5 in bc01a90

constructor(xcoord: number = 0, ycoord: number = 0, direction: string = 'north') {

for example don't :)

[Roshanjossey]

Should this change be made in https://github.com/exercism/typescript-analyzer/blob/master/.eslintrc or individual .eslintrc in project directories? Is there a mechanism by which these are synced?