Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

[Elisp] Fix directory name to match slug #151

Closed
wants to merge 2 commits into from
Closed

Conversation

ErikSchierboom
Copy link
Member

No description provided.

@benreyn
Copy link
Contributor

benreyn commented Jan 17, 2020

@ErikSchierboom, as a part of the transition to v3, I was wondering if it would make sense to "rebrand" elisp as "emacs lisp" in its references in exercism. It would be more accurate (the language is actually called "emacs lisp") Id love to chat about it though. I think not alot of people will recognize or "elisp" but if they see it as "emacs lips" they might be more intrigued to try out the track?

Thoughts?

(full disclosure, I know this may not exactly be straightforward and easy, what with trying to not break existing links, etc but wanted to bring it up anyway.)

@ErikSchierboom
Copy link
Member Author

@benreyn Ah I see! Well there is precedence to renaming tracks, so I think it is doable. Let me ping @iHiD, as I think he handled the previous rename.

@iHiD
Copy link
Member

iHiD commented Jan 17, 2020

It's fine to rename it but it would have to be emacs-lisp not emacs lisp.

Would you like me to do that?

@benreyn
Copy link
Contributor

benreyn commented Jan 17, 2020

I think that was my intention emacs-lisp. Needs to be a valid slug right?

@iHiD iHiD self-assigned this Jan 17, 2020
@iHiD
Copy link
Member

iHiD commented Jan 17, 2020

Mind opening an issue at exercism/elisp outlining the change, and assigning it to me. Then I'll sort it for you. Would be nice to have it documented in the main repo etc :)

@kotp
Copy link
Member

kotp commented Jan 17, 2020

but if they see it as "emacs lips" they might be more intrigued to try out the track? -- this comment

Not sure the reference, and it is quoted, however "lips" might still be a mistake? It is intriguing in itself, so proof that it does work at least for me.

@benreyn
Copy link
Contributor

benreyn commented Jan 17, 2020

HAHA, yes @kotp. That was meant to be "emacs-lisp"

@iHiD
Copy link
Member

iHiD commented Jan 19, 2020

@benreyn I've renamed the track. Please PR this change to rename the dir here :)

@iHiD
Copy link
Member

iHiD commented Jan 19, 2020

@benreyn Please also check things like CODEOWNERS too.

@ErikSchierboom
Copy link
Member Author

I think this PR should be closed.

@benreyn
Copy link
Contributor

benreyn commented Jan 20, 2020

Sorry, just catching from the weekend. Thanks for handling that rename @iHiD! Im going to start hitting the v3 track development in earnest this coming week.

@ErikSchierboom ErikSchierboom deleted the elisp branch January 20, 2020 16:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants