Add mentoring notes for java/reverse-string #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Already discussed in PR exercism#991
sshine
approved these changes
Jun 6, 2019
| String reverse(String inputString) { | ||
| String output = ""; | ||
| for (int i = inputString.length() - 1; i >= 0; i--) { | ||
| output += inputString.charAt(i); |
There was a problem hiding this comment.
Suggested change
| output += inputString.charAt(i); | |
| output += inputString.charAt(i); |
Indentation by 4 spaces.
| class ReverseString { | ||
| String reverse(String inputString) { | ||
| final int length = inputString.length(); | ||
| return IntStream.iterate(length-1, i-> i-1).limit(length) |
There was a problem hiding this comment.
Suggested change
| return IntStream.iterate(length-1, i-> i-1).limit(length) | |
| return IntStream.iterate(length - 1, i -> i - 1) | |
| .limit(length) |
Whitespace in lambda, align all chained methods.
| final int length = inputString.length(); | ||
| return IntStream.iterate(length-1, i-> i-1).limit(length) | ||
| .mapToObj(inputString::charAt) | ||
| .collect(StringBuilder::new, StringBuilder::append, StringBuilder::append).toString(); |
There was a problem hiding this comment.
Suggested change
| .collect(StringBuilder::new, StringBuilder::append, StringBuilder::append).toString(); | |
| .collect(StringBuilder::new, StringBuilder::append, StringBuilder::append) | |
| .toString(); |
Align all chained methods.
SleeplessByte
assigned SleeplessByte and michael-berger-FR and unassigned SleeplessByte
|
Not exactly sure how to do this, but I wanted to mention that this PR Fixes #1101 |
|
@michael-berger-FR: Hello. :-) It seems that I cannot push to your feature branch. Would you like to address my suggested changes? |
|
@jmrunkle: I think it's okay to not have a corresponding issue for each PR if the discussion is already documented here. |
|
I've committed the mentor notes sans whitespace formatting on the premise that they can be fixed later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Already discussed in PR #991