New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript/leap: Add mentor notes #642

Merged
merged 2 commits into from Dec 5, 2018

Conversation

Projects
None yet
3 participants
@SleeplessByte
Contributor

SleeplessByte commented Dec 2, 2018

Adds mentor notes based on the JavaScript notes, but greatly extended for typescript:

  • tslint mentions,
  • links to typescriptlang.org's handbook,
  • TypeScript specifics such as typing functions, type inference and boxed types.
@sshine

This comment has been minimized.

Contributor

sshine commented Dec 4, 2018

Very nice!

I think the last example has "by10" when "by100" was meant. Update: Also, are there cases of "is" with accent signs over the I, or am I getting short-sighted?

Fix function examples
Naturally this should be divisible by 100, not 10.
@SleeplessByte

This comment has been minimized.

Contributor

SleeplessByte commented Dec 4, 2018

@sshine That was definitely oversight 😅

Update: Also, are there cases of "is" with accent signs over the I, or am I getting short-sighted?

Yes, I think there are two instances of ís instead of is. I commonly use it (but also see it in the wild) when someone like myself wants to set something up to have extra emphasis.

In this case:

tslint will not warn when mixing && and ||, which ís a feature of eslint

It's also present in other notes but I'll gladly replace it with is or is, if that's what you prefer.

@sshine

sshine approved these changes Dec 5, 2018

@sshine sshine merged commit 6f6d608 into exercism:master Dec 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment