Ruby/Luhn New notes #875
Merged
Ruby/Luhn New notes #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New notes! I'd appreciate if we use this PR for correcting errors only. There's some urgency to merge, because there are several Luhns in the queue waiting for mentoring, and thus a great test case for the Notes. I opened a separate issue at the same time, where we can discuss the next iteration of the Luhn Notes.
|
@exercism/website-copy-ruby |
Let's put the reversing of the array (chars or numbers) inside the luhn sum calculation, instead of passing the reversed array to the calculator. Thanks @iHiD
pgaspar
requested changes
Mar 16, 2019
|
@pgaspar Made the changes, thnx |
pgaspar
approved these changes
Mar 16, 2019
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New notes!
I'd appreciate if we use this PR for correcting errors only. There's some urgency to merge, because there are several Luhns in the queue waiting for mentoring, and thus a great test case for the Notes.
I opened a separate issue #876 at the same time, where we can discuss the next iteration of the Luhn Notes.