Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto update maintainership #6990

Merged
merged 5 commits into from
Jul 23, 2024
Merged

Conversation

ErikSchierboom
Copy link
Member

Whenever we're adding people to track teams in GitHub, I always have to remember to also give them the maintainer role. This PR automates that.

Some open questions:

  • Do we want to support having maintainers that are not part of a track team?
  • Are only track team members eligible to be a maintainer, or are there more teams?

@iHiD
Copy link
Member

iHiD commented Jul 17, 2024

I thought I remembered this not working before, as the server doesn't have admin permissions. Am I misremembering?

  • Do we want to support having maintainers that are not part of a track team?

Yeah, possibly. Maybe people responsible for docs or snippet etc? I'm not hugely fussed either way though - I suspect there's no-one in this bucket atm.

  • Are only track team members eligible to be a maintainer, or are there more teams?

Is this the same question as above? It seems to be the same thing, written in the inverse. Am I misunderstanding?

@ErikSchierboom
Copy link
Member Author

I thought I remembered this not working before, as the server doesn't have admin permissions. Am I misremembering?

That was different as that tried to update things in GH. We're now doing things the other way around, updating our database when GH changes. This new strategy should work well, as bootstrap a track will add them to a GH team which we get notified about.

Yeah, possibly. Maybe people responsible for docs or snippet etc? I'm not hugely fussed either way though - I suspect there's no-one in this bucket atm.

🤷 It's not very hard to add them later on if we decide we want that. We can start with "only" having track team members auto become maintainers.

Is this the same question as above? It seems to be the same thing, written in the inverse. Am I misunderstanding?

I phrased this very badly, sorry. What I meant was: do we want to allow for exceptions, as in: can someone who is not in a track team be a maintainer? If so, we need some way of preventing the code in this PR from removing the maintainers role from that user when it runs.

@ErikSchierboom ErikSchierboom merged commit ad5d1f8 into main Jul 23, 2024
39 checks passed
@ErikSchierboom ErikSchierboom deleted the add-become-maintainer-command branch July 23, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants