Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exercise totals widget not working when viewing workout from calendar #46

Closed
jorre127 opened this issue Aug 11, 2022 · 4 comments
Closed
Labels
bug Something isn't working stale

Comments

@jorre127
Copy link
Contributor

The exercise totals widget seems to always display 0 when opening a workout from the calendar in view mode, in redo mode it seems to work fine.
Screenshot 2022-08-11 at 23 14 39

@KalleHallden
Copy link
Collaborator

Yeah it should work but it doesn't auto update as the reps and stuff change. It's a button, so you can press it and then it will update the numbers correctly. Not very well written, this was one of the smaller bugs that I had forgotten about hehe

@KalleHallden KalleHallden added the bug Something isn't working label Aug 17, 2022
@KalleHallden KalleHallden added this to the Smaller features milestone Aug 17, 2022
@ramsy0dev
Copy link
Contributor

can we save the total for each workout in the firestore then when viewing the workout it will display that total instead of recalculating eveything ?

@mfederowicz
Copy link
Contributor

maybe the problem is with implementation because when you click REDO button:

onPressed: () {
        Navigator.pop(context);
        Navigator.of(context).pop();
        Navigator.of(context).push(
          MaterialPageRoute(
            builder: (context) => WorkoutPage(widget.workout),
          ),
        );
      },

totals widget works well, and each button click shows proper values, but VIEW button have:

onPressed: () {
        addExercises(widget.workout);
        Navigator.pop(context);
      },

Iam just guesting, because for now my application flow knowledge is on beginning level :)

@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the stale label Sep 21, 2022
@stale stale bot closed this as completed Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

4 participants