add var in for loop #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If exif-js is required as a module then it throws an `Uncaught ReferenceError: n is not defined`. Added the proper scoping with var in order to solve this.
This was referenced Oct 24, 2017
Merged
|
@bartvanderwal Do you plan to release the fix on npm? Or will it be part of a larger one later on? |
|
@bartvanderwal +1 on including this in a release as soon as possible - this issue is making this library unusable for our application. In case it helps anyone else: angular-translate (https://github.com/angular-translate/angular-translate) / messageformat(https://github.com/messageformat) will export a global function called n() that is blown away by this bug in exif-js, causing translations to no longer function. |
|
@bartvanderwal +1 , please push hotfix to npm as soon as possible |
|
This code merge was 1 year ago. The npm version is still out-dated and unusable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If exif-js is required as a module then it throws an
Uncaught ReferenceError: n is not defined. Adding the proper scoping with var solves this issue.