This repository has been archived by the owner on Feb 24, 2022. It is now read-only.
Enable hot reload #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes `make run-local` to install any dependencies for both the app and api and starts both with hot reloading. The go server played nicer with sending to the background so I started it first. This also adds some minimal documentation in the README. This almost certainly won't work on Windows, but should on Mac/Linux (I tested on LMDE 3 Cindy). Windows development is something we'll need to support at some point in the interest of being accessible to anyone who wants to help. Fixes #32
mattgen88
reviewed
Mar 5, 2020
| To start a development server: | ||
|
|
||
| ```bash | ||
| make run-local |
There was a problem hiding this comment.
I'd probably suggest make dev over make run-local, which will build a containerized development environment so you don't need anything but docker.
run-local is the "you should know what you're doing" sort of environment.
mattgen88
approved these changes
Mar 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
make run-localto install any dependencies for both theapp and api and starts both with hot reloading. The go server played
nicer with sending to the background so I started it first. This also
adds some minimal documentation in the README.
This almost certainly won't work on Windows, but should on Mac/Linux (I
tested on LMDE 3 Cindy). Windows development is something we'll need to
support at some point in the interest of being accessible to anyone who
wants to help.
Fixes #32