This repository has been archived by the owner on Feb 24, 2022. It is now read-only.
Add internationalization #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I went with vue-i18n, as it seemed like the best option. I'm fairly sure I got everything, but we should probably move everything out of views and into components (like with Home). I have no idea how we're going to get translations for non-English languages: we'll have to rely on PRs for that. Closes #42
|
Whoops, forgot to commit the package.json. I’m away from my laptop but will add that in a few minutes. |
|
I’d also like to add linting (why wait for #35?): https://eslint-plugin-vue-i18n.intlify.dev/started.html#installation |
(and remembering to commit package.json this time)
|
The eslint config has support for something like |
mattgen88
previously approved these changes
Mar 8, 2020
|
Needs conflicts resolved, but otherwise good to go. There might be a few stragglers like the image alt, but I'm not super concerned with getting it all, just that we have the ability |
Merged
mattgen88
approved these changes
Mar 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went with vue-i18n, as it seemed like the best option. I'm fairly sure
I got everything, but we should probably move everything out of views
and into components (like with Home).
I have no idea how we're going to get translations for non-English
languages: we'll have to rely on PRs for that.
Closes #42