Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance regressions #40

Closed
avaer opened this issue Feb 25, 2017 · 7 comments
Closed

Performance regressions #40

avaer opened this issue Feb 25, 2017 · 7 comments

Comments

@avaer
Copy link
Member

avaer commented Feb 25, 2017

Need to re-profile and see what's eating CPU lately.
@avaer avaer self-assigned this Feb 25, 2017
@avaer
Copy link
Member Author

avaer commented Feb 25, 2017

Seems fine now.

@avaer avaer closed this as completed Feb 25, 2017
@avaer avaer reopened this Feb 25, 2017
@avaer
Copy link
Member Author

avaer commented Feb 25, 2017 •
edited
Loading

This could have been because of multiplayer.

  • Investigate that

@avaer
Copy link
Member Author

avaer commented Feb 25, 2017 •
edited
Loading

Slow code paths from the profile:

  • rend _updateKeyboardAnchors BoxTarget generation
  • update keyboard anchors when menu is opened
  • world _updateNpmAnchors BoxTarget generation
  • update npm anchors when menu is opened
  • Excessive ShadowMap renders: camera, and once per eye; it could just as well be only one
  • No need to use solidMaterial/MultiMaterials for tag meshes

@avaer
Copy link
Member Author

avaer commented Feb 25, 2017

☝️ Getting rid of the shadow map hits the frame target.

@avaer avaer mentioned this issue Feb 25, 2017
Merged
@avaer
Copy link
Member Author

avaer commented Feb 25, 2017 •
edited
Loading

Looks like too many drawcalls for tags rendering. Should use a single geometry + texture atlas. Indeed, getting rid of all tag meshes from the scene makes all the difference.

  • use a texture atlas for tag meshes
  • make number of textures a per-ui setting
  • merge tag mesh geometries, and return a proxy plane mesh object used to recompute geometry vertices
  • implement page garbage collection in uiManager
  • port mail engine to new biolumi API on rebase
  • anchor tracking for tag meshes does not work
  • regressed menu/keyboard positions
  • npm mesh tag selection is one off

@avaer avaer mentioned this issue Feb 26, 2017
Merged
@avaer avaer closed this as completed in #54 Feb 28, 2017
@avaer
Copy link
Member Author

avaer commented Feb 28, 2017

Reopening because some checkboxes remain.

@avaer avaer reopened this Feb 28, 2017
@avaer avaer removed their assignment Mar 3, 2017
@avaer
Copy link
Member Author

avaer commented Mar 11, 2017

Reportedly performance leaves something to be desired:

Surface book, 6th Gen Intel Core i7, 1TB SSD, 16GB RAM, Nvidia 940M

@avaer avaer mentioned this issue Mar 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@avaer