Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to skip ssl certificate validation #18

Closed
wants to merge 2 commits into from
Closed

Allow to skip ssl certificate validation #18

wants to merge 2 commits into from

Conversation

id
Copy link

@id id commented Dec 17, 2015

Our internal server has a poor ssl certificate and cs doesn't work with that one out of the box.

@brutasse
Copy link
Member

A more secure fix would be to pass the CA bundle to cs to make it validate your self-signed cert. Allowing verify=False makes it very easy to break the security chain.

Can you try passing a REQUESTS_CA_BUNDLE environment variable during your cs calls as explained in the requests docs?

@id
Copy link
Author

id commented Dec 17, 2015

Right. It worked, thanks.
Although the certificate is signed by a legitimate company root certificate, and that one is installed at /etc/pki/ca-trust/source/anchors/, requests could not find it.

@id id closed this Dec 17, 2015
@brutasse
Copy link
Member

Yeah, requests uses certifi which provides Mozilla's CA bundle and bypasses the system CA setup. Glad it's working fine now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants