config: accept verify=False

[greut]

This allows such configuration, which is mostly useful for special developer cases.

endpoint = https://192.168.1.1/compute
dangerous_no_tls_verify = false

http://docs.python-requests.org/en/master/user/advanced/?#ssl-cert-verification

[mcorbin]

Should we not throw an error message if the verify configuration is not correctly set ?

[greut]

Nope. https://docs.python-requests.org/en/master/user/advanced/?#ssl-cert-verification

[greut]

verify is of type Union[str, bool]

[brutasse]

I've tried to avoid adding such a possibility in the past, e.g. #18 and #27

The reasoning is that an insecure setup should be either hard to get or it should be obvious that it's insecure. If there really is no other way I'd love something in the spirit of hdparm's --yes-i-know-what-i-am-doing and --please-destroy-my-drive flags, i.e. something more glaring than verify=False.

[greut]

@brutasse requests comes with its own set of warnings once false is set.

[greut]

@brutasse verify = false still does nothing useful, but dangerous_no_tls_verify = true does.

[brutasse]

⚠️ ⚡