Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow ts-ignore in specs #47

Merged
merged 1 commit into from
Aug 4, 2020
Merged

feat: allow ts-ignore in specs #47

merged 1 commit into from
Aug 4, 2020

Conversation

Onatolich
Copy link
Contributor

No description provided.

nanovazquez
nanovazquez requested changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@nanovazquez nanovazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we allow ts ignore everywhere?
In which situation you need to tsignore in a spec?

@Onatolich
Copy link
Contributor Author

  1. I don't think that we should allow it everywhere because it is not safe.
  2. In tests it might be needed to allow passing not allowed values and test that an exception is thrown.

@Onatolich Onatolich merged commit b854cb5 into master Aug 4, 2020
@Onatolich Onatolich deleted the feat/allow-ts-ignore-in-specs branch August 4, 2020 22:28
@github-actions
Copy link

github-actions bot commented Aug 4, 2020

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanovazquez nanovazquez nanovazquez approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Onatolich @nanovazquez