Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support -- full stop CLI args #8

Closed
mattdesl opened this issue Jan 20, 2016 · 3 comments
Closed

Support -- full stop CLI args #8

mattdesl opened this issue Jan 20, 2016 · 3 comments

Comments

@mattdesl
Copy link
Contributor

As more flags are added to devtool CLI, they will start to pollute the flags that a program may want to use for whatever reason.

Maybe when a full stop is present, --, anything after that will be present in the process.argv for the running program, and the other flags (e.g. --browser-field) will be stripped.

devtool app.js --browser-field -- -q -b --blah
@halhenke
Copy link

Sounds good - is consistent with the way other tools solve this problem 👍

EDIT: I guess this is related (maybe also for #10 and #11) but I quickly commented out the lines adding .js extension to the file argument and I got this error messsage:
Unknown Flag: -harmony_arrow_functions. Run fly -h to see the options.
which seems to show node flags being passed to the program instead. Not sure if that should be a new issue or dealt with here?

@mattdesl
Copy link
Contributor Author

This is now supported in 1.2.1, it also cleans up gulp/grunt debugging. 🍻

@halhenke
Copy link

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants