'show authors feedback' link might show the wrong reviews #7
Labels
Milestone
Comments
yangsong8
pushed a commit
that referenced
this issue
Nov 21, 2016
Winbobob
pushed a commit
that referenced
this issue
Nov 9, 2018
Adding rspec test file for invitations_controller for mailers
efg
pushed a commit
that referenced
this issue
Feb 12, 2019
kunalnarangtheone
added a commit
to kunalnarangtheone/expertiza
that referenced
this issue
Mar 12, 2019
Winbobob
pushed a commit
that referenced
this issue
Jun 12, 2019
Final tests and Code Climate changes.
CarlColglazier
pushed a commit
to CarlColglazier/expertiza
that referenced
this issue
Oct 23, 2019
fix rspec test for git hub metrics controller
johnbumgardner
pushed a commit
that referenced
this issue
May 19, 2021
* Initial commit of answer_tags.js for 517Sp21 TeamTuffy * Implement basic review tag counter in view_team to count number of tags done vs not done. * Create very basic heatmap of tagged/untagged reviews. * Extend Heatmap Functionality: now autoloads and updates with each tag enabled/disabled. * Enable Show/Hide of Tag HeatGrid from toggle button; Hide on Load if no tags or if tags all done. * Fixed #7 Move majority of new JS code into view_team_in_grades.js from top of view_team.html.erb. * CSS change for heatgrid * Updated comment * Added css to updateTable in addition to generateTable * First table CSS changes * Implemented tag counters and display on page. * CSS change for heatgrid * Updated comment * Added css to updateTable in addition to generateTable * First table CSS changes * Add new tag counting algorithm that counts by question and review number, and populates heatgrid with tagless reviews in c0 grey style. * Deleted deprecated heatgrid functions in view_team_in_grades.js * Clean up comments and remove commented-out debug code from countTags() and drawTagGrid() * Added more CSS style inputs for table * Make heatgrid sizing more flexible for future changes in number / type of toggle-able tags. * Revise heading of heatgrid table text -- ReviewTags Completed. * Revise view_team.html.erb to move heatgrid anchor on page. * Revise view_team.html.erb to resolve newlines at eof causing build failure. * Handle heatgrid hiding bug when all tags are already done in view_team_in_grades.js * Troubleshoot build errors introduced after merge of E2057 Time travel not Allowed where assignment score publicity boolean is not expected when running test cases. * Add new HeatGrid state (collapsed) that only shows the row with the total count of completed tags, and accordions onClick * Change Tag Heatgrid CSS so grid respects layout rules of existing tables instead of rendering in an absolute position. * Added color legend to view_team heatgrid using tooltips. * Refactor rowData[] objects to an array of Maps instead of an array of Arrays so data can be accessed by key-value pairs instead of predetermined array indices. * Revert "Troubleshoot build errors introduced after merge of E2057 Time travel not Allowed where assignment score publicity boolean is not expected when running test cases." This reverts commit 03ed5e6. * Add jQuery toggle() call when Show/Hide tags is clicked to show/hide the tag heatgrid on view_team.html.erb * Add Review Round handling to tag heatgrid for multi-round reviews. * Code Cleanup -- Remove commented debug code and unnecessary comments in view_team_in_grades.js * Address Question/Criterion Inconsistency in legacy code on view_team.html.erb * Fixed issue with React row sorter breaking heatgrid color updates. * Remove debug <span> tag above heatgrid anchor from view_team.html.erb * Removed extra whitespace in several HTML tags to match zero-space convention used in rest of application eg, <div id = "..."> became <div id="..."> * Add countRounds() function and implement toggling of Round # -- prefix in tag heatgrid based on single vs multi-round reviews. * Accessibility for R/G Colorblind users: Add unicode symbols to tag heatgrid allowing users who cannot see the red/green spectrum well to read the heatgrid. * Add "if" statement in view_team.html.erb to ensure tagging report only queries and renders reviews of type, "ReviewQuestionnaire" for Instructor/TA view. * Correct scores view bug introduced with commit by laburges on November 14, 2020. Original commit changed boolean logic within the Assignment model, which broke score tables in the beta version. See comments for further information on this reversion/bugfix. * Removed hard-coded query against round 2, in Assignment model method, varying_rubrics_by_round?, so the boolean method compares all rounds, not just round 2. * Remove debug code: Restored dynamic population of data-roundnum field in <td> tag of view_team.html.erb * Revert changes in grades_controller, Assignment model, and _feedback_report * Reverting minor whitespace commit on _feedback_report.html.erb. * Reverting EOF whitespace in _feedback_report.html.erb * Revert minor whitespace change in assignment.rb * Revert changes in view_team.html.erb (Hex Code Capitalization) and whitespace in _feedback_report * Revert final EOF whitespace change in _feedback_report.html.erb * Correct toggleFunction() javascript style in view_team.html.erb * Correct toggleFunction() javascript style in view_team.html.erb * Refactor method names for clarity: getGridWidth(), getRowData() * Refactor drawTagGrid() to separate drawing of header, question rows, and review rows with new methods. * Amend comments in view_team_in_grades.js from E1788_OSS * New tests for Javascript calls and HTML elements in view_team.html.erb * Change heatgrid header to two rows to support # out of # and scale with table width. * Change heatgrid tooltip text to consistent capitalization, punctuation * Refactor html data- attribs to use correct style, clean up whitespace * Fix layout issue with Question Toggle zebra table jumping below tag grid. * Fix round counting bug in Round # Question # Rows * Clean up unnecessary comments in view_team_in_grades.js * Address reviews-not-rendering bug in view_team.html.erb introduced by E-2084 * Update grades controller spec to expect testing round [1, 2] instead of only round 2 * Update grades controller spec to expect testing round [1,2] instead of only round 2 * Added link * Hides info when no reviews to tag * Split oversized <td <%= ruby %>> tag on line 178 of view_team.html.erb into 3 lines. * Delete unused stub function collapseHeatGrid() in view_team_in_grades.js * Patch "Average peer review score: ##.##" not showing in view_team when multi-round reviews exist * Revert grades_controller and Assignment model changes * Finalize comment and formatting cleanup. * Add function comment to drawQuestionRow() * Add and clarify comments within view_team * Revert "Patch "Average peer review score: ##.##" not showing in view_team when multi-round reviews exist" This reverts commit 63b54cf. Co-authored-by: Stevan Dupor <smdupor@ncsu.edu> Co-authored-by: Jason Hurst <jmhurst@ncsu.edu> Co-authored-by: jmhurst1 <jasonhurst123226@gmail.com> Co-authored-by: J <cjl742952519@gmail.com> Co-authored-by: Jason Hurst <41127185+jmhurst1@users.noreply.github.com>
Closed
vinay-deshmukh
referenced
this issue
in Arvasu/expertiza
Nov 13, 2021
snehapriyaa
pushed a commit
that referenced
this issue
Jun 22, 2023
Questionnaire controller refactor
riyagori1203
pushed a commit
that referenced
this issue
Feb 1, 2024
Fixed a typo in latest_policies_controller_spec
riyagori1203
pushed a commit
that referenced
this issue
Feb 1, 2024
Refactor ta model, avoided nested loops, temporary arrays,.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
rsjohns3 on wiki textbook (see email re: Spontaneously generated author feedback):
http://expertiza.ncsu.edu/grades/view_my_scores/9926
When I click on the 'show authors feedback' link, sometimes I see all the reviews made by reviewers on my own topic (!!), and sometimes I see reviews by students of the review comments I posted for their topics. I am forced to reload my IE7 web page to correctly get the 'show authors feedback' link to work correctly
The text was updated successfully, but these errors were encountered: