E1771. [TLD] Refactor team.rb #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renaming get_node_type to node_type
Renaming get_author_names to author_names
Passing &:destroy to the each block for destroying the team
Using find_by instead of dynamic methods and where.first
Updating the tests in team_spec.rb
Dividing randomize_all_by_parent method into multiple sub methods Change done by sjbarai
darshil0193
force-pushed
the
refactor/team.rb
branch
from
0ced4de
to
01b3c75
Compare
darshil0193
force-pushed
the
refactor/team.rb
branch
from
a79173d
to
d72e055
Compare
|
Hi team, You refactoring looks good to me.
Thanks, |
|
Hi Zhewei, Thanks for the update. We'll complete the tests and try to remove the code climate errors and update the pull request. Thanks, |
Completed the remaining tests
Removing some minor and straight forward codeclimate errors
Solved a few more codeclimate issues
Reverting to use of each instead of find_each
Winbobob
reviewed
Nov 12, 2017
| end | ||
| end | ||
|
|
||
| def self.sort_teams_by_members_reverse(teams) |
There was a problem hiding this comment.
hmm, I don't think you need to extract one line of code as a new method. But it is not a big deal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all the minor refactoring related to the file. The two tasks left are updating the tests and refactoring self.randomize_all_by_parent function by disintegrating it in other smaller function. We are planning to submit these in next 3 days (by updating this pull request and removing the WIP mark).