E1981

[Jas0nch]

@Yashad

[expertiza-bot]

1 Message

💬

Thanks for the pull request, and welcome! 🎉 The Expertiza team is excited to review your changes, and you should hear from us soon. This repository is being automatically checked for code-quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a pull request is considered ready to review. Also, please spend some time looking at the instructions at the top of your course project writeup. If you have any questions, please send email to expertiza-support@lists.ncsu.edu.

	4 Warnings
⚠️	You are using global variables ($) or class variables (@@); please double-check whether this is necessary.
⚠️	You changed MARKDOWN (*.md) documents; please double-check whether it is necessary to do so. Alternatively, you can insert project-related content in the description field of the pull request.
⚠️	You modified spec/factories/ folder; please double-check whether it is necessary.
⚠️	In your tests, there are many expectations of elements on pages, which is good. To avoid shallow tests – tests concentrating on irrelevant, unlikely-to-fail conditions – please write more expectations to validate other things, such as database records, dynamically generated contents.

Generated by expertiza-bot

[coveralls]

Coverage increased (+11.2%) to 35.486% when pulling 71183aa on Jas0nch:beta into caf4c6c on expertiza:beta.

[coveralls]

Coverage increased (+0.03%) to 24.328% when pulling 71183aa on Jas0nch:beta into caf4c6c on expertiza:beta.

[expertiza-travisci-bot]

Travis tests have failed

Hey @Jas0nch,
Please click the following black triangle (▶) in order to see the detailed information.
It'll be awesome if you fix what's wrong and commit the changes.

Feature Tests:

Detailed Information

[Coveralls] Set up the SimpleCov formatter.
[Coveralls] Using SimpleCov's 'rails' settings.

Randomized with seed 58326
*****.........*****.....*.**.*...............................................*..............F.....*......*...F.*.............********.......................................**.........................******************.

Pending: (Failures listed here are expected and do not affect your suite's status)

  1) calibration when current assignment is in calibration stage calibration feature works correctly
     # Not yet implemented
     # ./spec/features/calibration_spec.rb:27

  2) calibration when current assignment is in review stage excludes calibration reviews from outstanding review restriction and total review restriction
     # Not yet implemented
     # ./spec/features/calibration_spec.rb:39

  3) calibration when current assignment is in review stage shows 'Review 1, 2, 3...' instead of 'Calibration review 1, 2, 3...' on student_review#list page
     # Not yet implemented
     # ./spec/features/calibration_spec.rb:41

  4) calibration in assignments#edit page has a checkbox with title 'Calibration for training?' on 'General' tab
     # Not yet implemented
     # ./spec/features/calibration_spec.rb:13

  5) calibration in assignments#edit page when clicking 'Calibration for training?' checkbox and clicking 'save' button 'Calibration' due date works correctly
     # Not yet implemented
     # ./spec/features/calibration_spec.rb:17

  6) badge system on participants#list page allows instructor to view badges assignment statuses of all participants
     # Not yet implemented
     # ./spec/features/badge_system_spec.rb:29

  7) badge system when a student receives a very high average teammate review grade (higher than 95 by default) assigns the 'Good teammate' badge to this student on student_task#list page
     # Not yet implemented
     # ./spec/features/badge_system_spec.rb:21

  8) badge system in assignments#edit page has a tab named 'Badges'
     # Not yet implemented
     # ./spec/features/badge_system_spec.rb:13

  9) badge system in assignments#edit page when switching to 'Badges' tab allows instructor to change the thresholds of two badges (by default is 95) and save thresholds to DB
     # Not yet implemented
     # ./spec/features/badge_system_spec.rb:16

  10) badge system when a student receives a very high review grades assigned by teaching staff (higher than 95 by default) assigns the 'Good reviewer' badge to this student on student_task#list page
     # Not yet implemented
     # ./spec/features/badge_system_spec.rb:25

  11) review mapping calculate review mapping from given review number per student
     # skip test on automated review mapping, too time consuming
     # ./spec/features/review_mapping_spec.rb:95

  12) review mapping show error when assign both 2
     # skip test on automated review mapping, too time consuming
     # ./spec/features/review_mapping_spec.rb:83

  13) review mapping calculate reviewmapping from given review number per submission
     # skip test on automated review mapping, too time consuming
     # ./spec/features/review_mapping_spec.rb:102

  14) review mapping show error when assign both 0
     # skip test on automated review mapping, too time consuming
     # ./spec/features/review_mapping_spec.rb:89

  15) assignment submisstion test should not submit invalid link
     # the error depends on the dns server. For spectrum network provider, invalid url will redirect to http://www.dnsrsearch.com
     # ./spec/features/assignment_submission_spec.rb:39

  16) assignment function creation page is able to create with staggered deadline
     # skip test on staggered deadline temporarily
     # ./spec/features/assignment_creation_spec.rb:146

  17) assignment function Due dates tab Able to create a new penalty policy
     # Temporarily skipped with xit
     # ./spec/features/assignment_creation_spec.rb:685

  18) assignment function review strategy tab sets number of reviews by each student
      # review section not yet completed
      Failure/Error: check 'num_reviews_student'
      
      Capybara::ElementNotFound:
        Unable to find visible checkbox "num_reviews_student" that is not disabled
      # ./spec/features/assignment_creation_spec.rb:645:in `block (3 levels) in <top (required)>'

  19) timestamps for student's submissions when current assignment (with single review round) is in review stage after current participant finishes an author feedback displays a link named 'feedback' with its timestamps (you could redirect to that feedback by clicking the link)
     # Not yet implemented
     # ./spec/features/timestamps_for_students_submissions_spec.rb:36

  20) timestamps for student's submissions when current assignment (with single review round) is in review stage after current participant reviews other's work displays a link named 'review' with its timestamps (you could redirect to that review by clicking the link) 
     # Not yet implemented
     # ./spec/features/timestamps_for_students_submissions_spec.rb:30

  21) timestamps for student's submissions when current assignment is in submission stage after current participant has submitted a hyperlink displays hyperlinks with its timestamps
     # Not yet implemented
     # ./spec/features/timestamps_for_students_submissions_spec.rb:18

  22) timestamps for student's submissions when current assignment is in submission stage after current participant has uploaded a file displays file names with its timestamps
     # Not yet implemented
     # ./spec/features/timestamps_for_students_submissions_spec.rb:23

  23) timestamps for student's submissions when current assignment is in submission stage when current participant does not submit anything yet displays due dates of current assignment in student_task#list page
     # Not yet implemented
     # ./spec/features/timestamps_for_students_submissions_spec.rb:14

  24) timestamps for student's submissions when current assignment (with multiple review round) is in review stage after current participant reviews other's work in round 2 displays a link named 'review' with its round number (2) and timestamps (you could redirect to that review by clicking the link)
     # Not yet implemented
     # ./spec/features/timestamps_for_students_submissions_spec.rb:51

  25) timestamps for student's submissions when current assignment (with multiple review round) is in review stage after current participant finishes an author feedback displays a link named 'feedback' with its timestamps (you could redirect to that feedback by clicking the link)
     # Not yet implemented
     # ./spec/features/timestamps_for_students_submissions_spec.rb:58

  26) timestamps for student's submissions when current assignment (with multiple review round) is in review stage after current participant reviews other's work in round 1 displays a link named 'review' with its round number (1) and timestamps (you could redirect to that review by clicking the link)
     # Not yet implemented
     # ./spec/features/timestamps_for_students_submissions_spec.rb:45

  27) expert review when current assignment with single review round supports expert peer-review expert review feature works correctly
     # Not yet implemented
     # ./spec/features/expert_review_spec.rb:14

  28) expert review when current assignment with vary-rubric-by-round supports expert peer-review expert review feature works correctly
     # Not yet implemented
     # ./spec/features/expert_review_spec.rb:28

  29) team invitation when current assignment is a team-based assignment with topics on student_teams#view page (student end) shows a list of students who do not have a team and team owner can invite these students by clicking the 'invite' buttons
     # Not yet implemented
     # ./spec/features/team_invitation_spec.rb:44

  30) team invitation when current assignment is a team-based assignment with topics on student_teams#view page (student end) when invitee declining the invitation makes team members remain the same as before
     # Not yet implemented
     # ./spec/features/team_invitation_spec.rb:47

  31) team invitation when current assignment is a team-based assignment with topics on student_teams#view page (student end) when invitee accepting the invitation when the team is already full makes team members remain the same as before
     # Not yet implemented
     # ./spec/features/team_invitation_spec.rb:56

  32) team invitation when current assignment is a team-based assignment with topics on student_teams#view page (student end) when invitee accepting the invitation when the team is not full makes invitee joins the team
     # Not yet implemented
     # ./spec/features/team_invitation_spec.rb:52

  33) team invitation when current assignment is a team-based assignment with topics when a student access studet_task#list page of this assignment contains 'Your team' link on the page
     # Not yet implemented
     # ./spec/features/team_invitation_spec.rb:14

  34) team invitation when current assignment is a team-based assignment with topics advertisement feature when team owner declining the invitation makes team members remain the same as before
     # Not yet implemented
     # ./spec/features/team_invitation_spec.rb:29

  35) team invitation when current assignment is a team-based assignment with topics advertisement feature when team owner accepting the invitation when the team is already full makes team members remain the same as before
     # Not yet implemented
     # ./spec/features/team_invitation_spec.rb:38

  36) team invitation when current assignment is a team-based assignment with topics advertisement feature when team owner accepting the invitation when the team is not full makes requester joins the team
     # Not yet implemented
     # ./spec/features/team_invitation_spec.rb:34

  37) team invitation when current assignment is a team-based assignment with topics on teams#list page (instructor end) shows a list of students who do not have a team
     # Not yet implemented
     # ./spec/features/team_invitation_spec.rb:62

  38) team invitation when current assignment is not a team-based assignment when a student access studet_task#list page of this assignment does not contain 'Your team' link on the page
     # Not yet implemented
     # ./spec/features/team_invitation_spec.rb:68

  39) Team Creation one student who has a topic sends an invitation to other student who also has a topic Student should aceept the invitation sent by the other student and both have topics
     # Temporarily skipped with xdescribe
     # ./spec/features/team_creation_spec.rb:122

  40) Team Creation one student who has a topic sends an invitation to other student who also has a topic student should reject the invitation sent by the other student and both gave topics
     # Temporarily skipped with xdescribe
     # ./spec/features/team_creation_spec.rb:128

  41) Team Creation one student should send an invitation to other student and both does not have topics Student should reject the other students invitaton and both dont have a topic
     # Temporarily skipped with xdescribe
     # ./spec/features/team_creation_spec.rb:187

  42) Team Creation one student should send an invitation to other student and both does not have topics Student should accept other students invitation and both does not have a topic
     # Temporarily skipped with xdescribe
     # ./spec/features/team_creation_spec.rb:181

  43) Team Creation one student should send an invitation to other student who has a topic signed up for Student should reject the inviattion sent by the other student who has a topic
     # Temporarily skipped with xdescribe
     # ./spec/features/team_creation_spec.rb:243

  44) Team Creation one student should send an invitation to other student who has a topic signed up for Student should accept the invitation sent by other student who has a topic
     # Temporarily skipped with xdescribe
     # ./spec/features/team_creation_spec.rb:237

  45) Team Creation one student who signup for a topic should send an inviatation to the other student who has no topic is able to accept the invitation and form team
     # Temporarily skipped with xdescribe
     # ./spec/features/team_creation_spec.rb:57

  46) Team Creation one student who signup for a topic should send an inviatation to the other student who has no topic is not able to form team on rejecting
     # Temporarily skipped with xdescribe
     # ./spec/features/team_creation_spec.rb:63


Failures:

  1) assignment function creation page is able to create a public assignment
     Failure/Error:
       child_nodes.each do |node|
         initialize_fnode_update_children(params, node, tmp_res)
       end
     
     NoMethodError:
       undefined method `each' for "":String
     # ./app/controllers/tree_display_controller.rb:209:in `children_node_ng'
     # ./config/diagnostic.rb:11:in `call'
     # ------------------
     # --- Caused by: ---
     # Capybara::CapybaraError:
     #   Your application server raised an error - It has been raised in your test code because Capybara.raise_server_errors == true
     #   /home/travis/build/expertiza/expertiza/vendor/bundle/ruby/2.2.0/gems/capybara-2.17.0/lib/capybara/session.rb:145:in `raise_server_error!'

  2) assignment function rubrics tab Edit review rubric updates review questionnaire
     Failure/Error:
       child_nodes.each do |node|
         initialize_fnode_update_children(params, node, tmp_res)
       end
     
     NoMethodError:
       undefined method `each' for "":String
     # ./app/controllers/tree_display_controller.rb:209:in `children_node_ng'
     # ./config/diagnostic.rb:11:in `call'
     # ------------------
     # --- Caused by: ---
     # Capybara::CapybaraError:
     #   Your application server raised an error - It has been raised in your test code because Capybara.raise_server_errors == true
     #   /home/travis/build/expertiza/expertiza/vendor/bundle/ruby/2.2.0/gems/capybara-2.17.0/lib/capybara/session.rb:145:in `raise_server_error!'

Finished in 7 minutes 6 seconds (files took 4.43 seconds to load)
218 examples, 2 failures, 46 pending

Failed examples:

rspec ./spec/features/assignment_creation_spec.rb:56 # assignment function creation page is able to create a public assignment
rspec ./spec/features/assignment_creation_spec.rb:556 # assignment function rubrics tab Edit review rubric updates review questionnaire

Randomized with seed 58326

Coverage report generated for RSpec to /home/travis/build/expertiza/expertiza/coverage. 4294 / 14409 LOC (29.8%) covered.
[Coveralls] Submitting to https://coveralls.io/api/v1
[Coveralls] Job #8872.1
[Coveralls] https://coveralls.io/jobs/56970168
Coverage is at 29.8%.
Coverage report sent to Coveralls.

[Yashad]

Extra space.

[Jas0nch]

closed and reopen a pull request

[Jas0nch]

Hi @Yashad and Prof @efg,

I tried to create a new pull request and remove the unnecessary changes for README.md and schema.rb, but I got a failed pr.

I don't know why it failed. I think the reason might be I didn't change the schema.rb file so the migration won't work, any suggestions for this situation?

And when I reopen this pull request, it failed even it succeed previously. It seems weird to me.