Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E1981 Student-generated questions added to rubric #1664

Closed
wants to merge 1 commit into from
Closed

E1981 Student-generated questions added to rubric #1664

wants to merge 1 commit into from

Conversation

Jas0nch
Copy link

@Jas0nch Jas0nch commented Dec 18, 2019

E1981 Student-generated questions added to rubric
see more info at wiki

@expertiza-bot
Copy link
Contributor

expertiza-bot commented Dec 18, 2019

1 Message
💬 Thanks for the pull request, and welcome! 🎉 The Expertiza team is excited to review your changes, and you should hear from us soon.

This repository is being automatically checked for code-quality issues using Code Climate.
You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a pull request is considered ready to review.

Also, please spend some time looking at the instructions at the top of your course project writeup.
If you have any questions, please send email to expertiza-support@lists.ncsu.edu.

3 Warnings
⚠️ You are using global variables ($) or class variables (@@); please double-check whether this is necessary.
⚠️ You modified spec/factories/ folder; please double-check whether it is necessary.
⚠️ In your tests, there are many expectations of elements on pages, which is good.
To avoid shallow tests – tests concentrating on irrelevant, unlikely-to-fail conditions – please write more expectations to validate other things, such as database records, dynamically generated contents.

Generated by expertiza-bot

@expertiza-travisci-bot
Copy link

Hey @Jas0nch,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

@Jas0nch Jas0nch closed this Dec 18, 2019
@Jas0nch Jas0nch deleted the hcao5 branch December 18, 2019 03:48
@Jas0nch Jas0nch mentioned this pull request Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants