Merge AdviceController and tests refactor #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial files
there is one migrate
Initial tests running and starting point
Reimplemented edit advice method
Save method refactor
…h private method. To make DRY
refactor to before action
Added tests for edit_advice method
refactoring invalid_advice and updating tests Pulled this branch being merged and everything tests well.
Final updates for edit_advice method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored AdviceController methods.
Added gem rails-controller-testing to get access to render_template
Modified ApplicationController to inherit from Base instead of Api. Should have a separate class for api controller to inherit from in the future. Also added some user based methods to ApplicationController
Added missing classes needed for testing
Added routes to AdviceController
Added some factories for rspec testing and a rails helper to allow session users to be created for tests.