Reimplemented edit advice method #9
Conversation
|
|
||
| # Function to calculate number of advices for the current question attribute based on max and min question score. | ||
| # Method name is consistent with the functionality | ||
| def calculate_num_advices(question) |
There was a problem hiding this comment.
I think you could simplify this into more modern grammar. Something like question.is_a?(ScoreQuestion) ? :
There was a problem hiding this comment.
if question.is_a?(ScoredQuestion) This line checks if the current question attribute is scored or not by checking if it is of the type 'ScoredQuestion'. Don't you think 'ScoredQuestion' makes more sense in that case?
There was a problem hiding this comment.
What I meant exactly was changing it to this
question.is_a?(ScoredQuestion) ? @questionnaire.max_question_score - @questionnaire.min_question_score + 1 : 0
It feels much more modern and elegant.
There was a problem hiding this comment.
Oh okay, I understand now. My bad. I will make the necessary changes.
There was a problem hiding this comment.
I have updated the file.
No description provided.