Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge AdviceController and tests refactor #99

Closed
wants to merge 25 commits into from
Closed

Merge AdviceController and tests refactor #99

wants to merge 25 commits into from

Commits on Apr 4, 2024

  1. Adding a lot of initial files and factories needed

    @bdevine2
    bdevine2 committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    49a15b0 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from AdrYne01/add_initial_files 

    Initial files
    @AdrYne01
    AdrYne01 committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    dfece04 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. These are all the changes to get rspec running. 

    there is one migrate
    @bdevine2
    bdevine2 committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    217445a View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Merge pull request #8 from AdrYne01/initial_setup_get_running 

    Initial tests running and starting point
    @bdevine2
    bdevine2 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    eb3b2c7 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2024

  1. Reimplemented edit advice method

    @AdrYne01
    AdrYne01 committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    a1e26c0 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Updated edit_advice method

    @AdrYne01
    AdrYne01 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    538e7c3 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #9 from AdrYne01/reimplement-edit-advice-method 

    Reimplemented edit advice method
    @bdevine2
    bdevine2 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    91ac933 View commit details
    Browse the repository at this point in the history

  3. Updated controller save method

    @bdevine2
    bdevine2 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    8b5db0c View commit details
    Browse the repository at this point in the history

  4. Update save method rspec tests based on test skeleton provided

    @bdevine2
    bdevine2 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    3be59d5 View commit details
    Browse the repository at this point in the history

  5. Gem update for rspec testing

    @bdevine2
    bdevine2 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    8b6de5f View commit details
    Browse the repository at this point in the history

  6. Final commit with superclass change for controllers and missing erb f… 

    …or testing
    @bdevine2
    bdevine2 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    bebf4a1 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Merge pull request #10 from AdrYne01/save_advice_refac_and_tests 

    Save method refactor
    @bdevine2
    bdevine2 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    3540db1 View commit details
    Browse the repository at this point in the history

  2. Moved the setting of questionnaire into more modern before action wit… 

    …h private method. To make DRY
    @bdevine2
    bdevine2 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    e882f7b View commit details
    Browse the repository at this point in the history

  3. Merge pull request #11 from AdrYne01/refactor_set_questionnaire 

    refactor to before action
    @bdevine2
    bdevine2 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    364c7a2 View commit details
    Browse the repository at this point in the history

  4. Added tests for edit_advice method

    @AdrYne01
    AdrYne01 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    9a910d4 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Deleted duplicate questionnaire helper file

    @AdrYne01
    AdrYne01 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    ba4ce13 View commit details
    Browse the repository at this point in the history

  2. updated edit advice method

    @AdrYne01
    AdrYne01 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    ed4e141 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #12 from AdrYne01/edit_advice_tests 

    Added tests for edit_advice method
    @bdevine2
    bdevine2 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    7e62e6a View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. refactoring invalid_advice and updating tests

    @aebartl3
    aebartl3 committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    5db9a88 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #15 from AdrYne01/refactor_implement_advice 

    refactoring invalid_advice and updating tests

Pulled this branch being merged and everything tests well.
    @bdevine2
    bdevine2 committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    4cbf064 View commit details
    Browse the repository at this point in the history

  3. implementing new invalid_advice change

    @aebartl3
    aebartl3 committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    e21d158 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #16 from AdrYne01/refactor_implement_advice 

    Looks good
    @bdevine2
    bdevine2 committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    3439ac8 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Final updates for edit_advice method

    @AdrYne01
    AdrYne01 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    2956063 View commit details
    Browse the repository at this point in the history

  2. Added database.yml.example

    @AdrYne01
    AdrYne01 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    b9eaa2b View commit details
    Browse the repository at this point in the history

  3. Merge pull request #17 from AdrYne01/final-update-edit-advice 

    Final updates for edit_advice method
    @AdrYne01
    AdrYne01 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    702d0fc View commit details
    Browse the repository at this point in the history