Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a default dtype to model configs #330

Merged
merged 3 commits into from Sep 19, 2023
Merged

Add a default dtype to model configs #330

merged 3 commits into from Sep 19, 2023

Conversation

shadeMe
Copy link
Collaborator

@shadeMe shadeMe commented Sep 18, 2023

Description

This lets us fallback to a known/expected datatype if the HF model config doesn't contain that metadata.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.

@shadeMe shadeMe added type/feature Type: Feature feat/model Feature: models labels Sep 18, 2023
@danieldk danieldk merged commit 84246c9 into explosion:main Sep 19, 2023
9 checks passed
@shadeMe shadeMe deleted the feature/default-model-dtype branch September 19, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
feat/model Feature: models type/feature Type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shadeMe @danieldk