Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make 04_fasttext_train_vectors.py and 05_export.py compatible wi… #106

Merged
merged 1 commit into from
May 29, 2020

Conversation

dshefman1
Copy link

fix: make 04_fasttext_train_vectors.py and 05_export.py compatible with Windows 10
docs: update requirements.txt with fastText library reference and version
feat: add functionality to save fastText model to disk to avoid retraining the model
feat: give control to the user to choose # of epochs
feat: add functionality to load saved fastText model from disk to create vocab.txt and vectors.txt
feat: add more warning, fail, and good messages for the user

…th Windows 10

docs: update requirements.txt with fastText library reference and version
feat: add functionality to save fastText model to disk to avoid retraining the model
feat: give control to user to choose # of epochs
feat: add functionality to load saved fastText model from disk to create vocab.txt and vectors.txt
feat: add more warning, fail, and good messages for user
@svlandeg svlandeg added bug Bugs and behaviour differing from documentation scripts Code examples in /scripts labels Apr 21, 2020
@svlandeg svlandeg added enhancement Feature requests and improvements and removed bug Bugs and behaviour differing from documentation labels Apr 24, 2020
@svlandeg
Copy link
Member

(cf discussion over at Issue #105)

@svlandeg svlandeg mentioned this pull request Apr 28, 2020
@svlandeg
Copy link
Member

svlandeg commented May 4, 2020

@honnibal and @ines : would like to get your feedback whether this approach is OK!

@honnibal
Copy link
Member

Thanks! I haven't tested it myself but it looks reasonable, so I'll go ahead and trust :)

@honnibal honnibal merged commit c22078c into explosion:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests and improvements scripts Code examples in /scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help Re-writing 04_fasttext_train_vectors.py for Windows 10 Compatibility
4 participants